fix(startup): invoke MCP installation as a Python module - #107
Open
LinXunFeng wants to merge 1 commit into
Open
LinXunFeng wants to merge 1 commit into
LinXunFeng wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Running
./start.shwith uv 0.5.9 from the repository root can fail during MCP installation because uv executes the localartemisdirectory. This allowsartemis/platformto shadow the standard-library module and causes alangsmith.RunTreeimport error.Use
uv run python -m artemisfor MCP installation and its printed retry instructions, matching the existing UI launch command.Closes #106
Validation
Passed:
bash -n start.shbash start.sh --helpuv run python -m artemis mcp --helpuv run python -m artemis mcp --install allgit diff --checkmake typecheckuv run python scripts/quality_ratchet.pyAdditional repository checks:
make test: 2108 passed, 81 failed, 6 skipped, 8 deselected.Failures include missing Gemini credentials and assertions outside the changed startup script.
make lint: formatting passed; Ruff reported 11 existing violations inplayground/backend_manager.Only
start.shis changed. No dependency changes.