fix(client): preserve numeric zero in task result turn counts - #104
Open
Chris0Jeky wants to merge 1 commit into
Open
Chris0Jeky wants to merge 1 commit into
Chris0Jeky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103.
TaskResult.from_payload()currently treats numericturns=0as missing:result.turnsbecomesNone, or usescurrent_turnwhen that alias is present.String
"0"already works.This patch preserves numeric zero and its precedence while keeping existing
fallback for null, empty strings and
False;Truestill converts to 1. Rawpayloads and other field parsing are unchanged.
At base
371aa6df56880643da57b30da936e9812fb0ec66, the zero regressions fail.At head
c5f29e69d5739e3253d8297e60d2d870776ba729, all 24 client tests and20 subtests pass on Windows/Python 3.12.14, with imports verified against this
package. Restoring the old parser makes the regressions fail again.
Package lint/format, protected-core types and the quality ratchet pass.
The fork CI run
passes frontend/build and package smoke; both Python jobs stop at the same
11 pre-existing Ruff findings in
playground/backend_manager. An isolated Linux comparisonhas the same 95 failed IDs on base and patch (2090 versus 2094 passed); its
environment-modified baseline is red. This is a parser correction, without a
live-server reproduction or a full-suite pass.