host_orchestrator: reject archive entries that escape the extraction dir - #3016
Open
0405ysj wants to merge 3 commits into
Open
host_orchestrator: reject archive entries that escape the extraction dir#30160405ysj wants to merge 3 commits into
0405ysj wants to merge 3 commits into
Conversation
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
0405ysj
marked this pull request as ready for review
August 13, 2026 04:15
We curl this URL, which is now broken. google#2981 is considering using bazelisk, but the scripts and presubmits are broken now, so we should fix this now.
The user-artifacts extractor (ExtractArtifact -> untar/unzip) joined attacker-controlled archive entry names onto the destination directory with no containment check and created symlink entries verbatim, allowing a crafted .tar.gz/.zip to write files outside the extraction directory Add isSafeToExtract() and use it in untar and unzip to verify each entry's resolved path stays within the destination, and reuse it to reject symlink entries whose resolved target escapes it. Add regression tests for the tar-traversal, tar-symlink and zip-traversal vectors.
0405ysj
force-pushed
the
security_patch_1_56
branch
from
August 13, 2026 04:25
4c696b8 to
cb8d843
Compare
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user-artifacts extractor (ExtractArtifact -> untar/unzip) joined attacker-controlled archive entry names onto the destination directory with no containment check and created symlink entries verbatim, allowing a crafted .tar.gz/.zip to write files outside the extraction directory
Add isSafeToExtract() and use it in untar and unzip to verify each entry's resolved path stays within the destination, and reuse it to reject symlink entries whose resolved target escapes it. Add regression tests for the tar-traversal, tar-symlink and zip-traversal vectors.