Proxy --acpi-table, --device-tree-overlay, and --file-backed-mapping to crosvm run - #2960
Open
erjiaqing wants to merge 4 commits into
Open
Proxy --acpi-table, --device-tree-overlay, and --file-backed-mapping to crosvm run#2960erjiaqing wants to merge 4 commits into
erjiaqing wants to merge 4 commits into
Conversation
…to crosvm run Introduce new gflags and cuttlefish config properties to allow proxying user provided ACPI tables, device tree overlays, and file-backed mappings to crosvm run command. These options are passed when starting the main crosvm runner command. Assisted-by: Antigravity:Gemini-Next TAG=agy CONV=2a93473d-f5c9-4f0d-89a1-b07cb069a790
Databean
reviewed
Aug 6, 2026
GET_FLAG_STR_VALUE splits on commas to separate arguments for different instances. This interacts badly with crosvm_file_backed_mapping's comma-separated arguments (addr=NUM,size=NUM...). Support base64-encoded crosvm_file_backed_mapping to allow correct argument division between instances in multi-device clusters. TAG=agy CONV=d50a8a3c-a4cd-4ba2-97cc-cfaf7a4ec28c
Databean
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL Introduce new command line arguments and cuttlefish config properties to allow proxying user provided ACPI tables, device tree overlays, and file-backed mappings to
crosvm runcommand.Assisted-by: Antigravity:Gemini-Next
Bug: 510177847