Skip to content

fix(sessions): allow builtins.getattr in migration unpickler for py31… - #7057

Open
manish08k wants to merge 1 commit into
google:mainfrom
manish08k:fix-migration-unpickler
Open

fix(sessions): allow builtins.getattr in migration unpickler for py31…#7057
manish08k wants to merge 1 commit into
google:mainfrom
manish08k:fix-migration-unpickler

Conversation

@manish08k

Copy link
Copy Markdown

…1 + crewai

Please ensure you have read the contribution guide before creating a pull request.

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

  • Closes: #issue_number
  • Related: #issue_number

2. Or, if no issue exists, describe the change:

If applicable, please follow the issue templates to provide as much detail as
possible.

Problem:
A clear and concise description of what the problem is.

Solution:
A clear and concise description of what you want to happen and why you choose
this solution.

Testing Plan

Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

Please include a summary of passed pytest results.

Manual End-to-End (E2E) Tests:

Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@sarathak

sarathak commented Sep 8, 2026

Copy link
Copy Markdown

Hi @manish08k — not a maintainer here, just came across this PR. The fix itself looks reasonable: adding ("builtins", "getattr") to the allow-list for the Python 3.11 pickle_by_enum_name case, and the inline comment explaining why it's safe (the getattr target is itself gated by the same find_class check) makes sense to me.

A couple of things that might help this move through review, since the PR description is still the unfilled template:

  • Problem description: it'd help reviewers to know what triggered this
  • Tests: the checklist and testing plan are both empty. A small regression test that unpickles a pickle_by_enum_name-style payload on 3.11 (and would fail without this change) would make the fix easy to verify.

Might make it easier for a maintainer to review and merge quickly. Nice catch on the underlying issue either way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants