feat(utils): add opt-in Jinja2 instruction templating via use_jinja2 flag#6186
Open
vaibhav-patel wants to merge 2 commits into
Open
feat(utils): add opt-in Jinja2 instruction templating via use_jinja2 flag#6186vaibhav-patel wants to merge 2 commits into
vaibhav-patel wants to merge 2 commits into
Conversation
…flag
Add a `use_jinja2: bool = False` flag to `inject_session_state` that, when
enabled, renders the instruction template with a sandboxed Jinja2 environment
instead of the existing regex-based `{var}` substitution. This unlocks control
flow (conditionals, loops) and filters in agent instructions while keeping the
default behavior fully backward compatible.
The regex rendering logic is extracted unchanged into `_render_with_regex`, and
a new `_render_with_jinja2` coroutine handles the Jinja2 path. It exposes the
session `state` mapping and an async `artifact(name)` accessor to templates;
the environment runs with `enable_async=True` so the artifact coroutine is
awaited automatically, and missing artifacts render as empty strings.
jinja2 is imported lazily inside the Jinja2 path so the base install is not
forced to depend on it, and a dedicated `jinja` optional extra documents the
install path (`pip install google-adk[jinja]`). A
`jinja2.sandbox.SandboxedEnvironment` is used because instruction templates may
carry user/session data.
Adds unit tests for variable substitution, conditionals, loops, filters,
artifact loading, the uninitialized-artifact-service error, the sandbox
blocking unsafe attribute access, and confirmation that the default path is
unchanged.
Fixes google#2942.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
use_jinja2flag toinject_session_state(src/google/adk/utils/instructions_utils.py). When enabled, instruction templates are rendered with a sandboxed Jinja2 environment, unlocking control flow ({% if %},{% for %}) and filters in addition to the existing{var}substitution. The default (use_jinja2=False) is fully backward compatible.Changes
_render_with_regex._render_with_jinja2, which renders viajinja2.sandbox.SandboxedEnvironment(enable_async=True)and exposes:state— the session state mapping ({{ state['var'] }}).artifact— an async accessor ({{ artifact('file') }}), auto-awaited by the async environment; missing artifacts render as empty string.jinja2lazily so the base install isn't forced to depend on it; add ajinjaoptional extra (pip install google-adk[jinja]).Notes for reviewers
jinja2is not a core dependency today (only in theeval/testextras). I added a dedicatedjinjaoptional extra rather than touching core deps. Happy to fold it into core deps or another extra if you prefer.{{ await artifact(...) }}; that syntax is invalid in Jinja2. Withenable_async=Truethe coroutine is awaited automatically, so the supported syntax is{{ artifact('file') }}.Testing
Added unit tests for variable substitution, conditionals, loops, filters, artifact loading, the uninitialized-artifact-service error, sandbox rejection of unsafe attribute access, and an explicit check that the default path is unchanged. All
tests/unittests/utils/test_instructions_utils.pypass (24).Fixes #2942.