Repository navigation
Conversation
pgentile
marked this pull request as ready for review
August 19, 2026 15:07
pgentile
force-pushed
the
rag_retrieval_similarity_top_k
branch
from
August 19, 2026 15:07
71cd444 to
2493cd1
Compare
Contributor
|
Hi @pgentile, thank you for your contribution! We appreciate you taking the time to submit this pull request. Currently this PR is under review by our team we will keep you posted if any additional information is required. thank you. |
Author
|
Hi @hemasekhar-p, Do you know when this PR will be reviewed? The configuration of this parameter is already available in the Python and Kotlin SDKs. Thanks |
damianmomotgoogle
requested changes
Oct 16, 2026
|
I've addressed your review feedback and pushed the fixes. Thanks 🙏 |
damianmomotgoogle
requested changes
Oct 19, 2026
damianmomotgoogle
left a comment
Contributor
There was a problem hiding this comment.
Thx! Can you squash all commits into a single one with conventional commits message ?
pgentile
force-pushed
the
rag_retrieval_similarity_top_k
branch
from
October 19, 2026 13:49
01a2182 to
fa0331c
Compare
Author
|
The commits are now squashed. |
New builder for the VertexAiRagRetrieval class to configure the similarity top-K parameter
pgentile
force-pushed
the
rag_retrieval_similarity_top_k
branch
from
October 19, 2026 13:54
fa0331c to
71bd1cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem:
Add support for the similarity top-K parameter in the
VertexAiRagRetrievaltoolSolution:
New
similarityTopKconstructor parameter in the constructor of theVertexAiRagRetrievalclass.The similarity top-K is then added to the LLM request, when the model is a Gemini one and when the
GOOGLE_GENAI_USE_VERTEXAIenv var is enabled. Otherwise, the similarity top-K parameter is transmitted to theretrieveContextsmethod.Testing Plan
Updates of the
VertexAiRagRetrievalTestunit test.Unit Tests:
Manual End-to-End (E2E) Tests:
GOOGLE_GENAI_USE_VERTEXAIenv var.Checklist
Additional context
N/A