Remove the ExternalBuffer class and use Buffer instead. - #11152
Open
copybara-service[bot] wants to merge 1 commit into
Open
Remove the ExternalBuffer class and use Buffer instead.#11152copybara-service[bot] wants to merge 1 commit into
ExternalBuffer class and use Buffer instead.#11152copybara-service[bot] wants to merge 1 commit into
Conversation
This removes a helper class to reuse the existing buffers, allowing to directly share a buffer from another source instead of manually trying to keep track of views and copied buffers. This also allows us to lock the buffers when needed and only keep them locked for the duration of a run. Previously we would lock a buffer, keep it as a view and unlock it, which is a bug and only worked for data that resides in the host memory. PiperOrigin-RevId: 976559332
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
ExternalBufferclass and useBufferinstead.This removes a helper class to reuse the existing buffers, allowing to
directly share a buffer from another source instead of manually trying
to keep track of views and copied buffers.
This also allows us to lock the buffers when needed and only keep them
locked for the duration of a run. Previously we would lock a buffer,
keep it as a view and unlock it, which is a bug and only worked for data
that resides in the host memory.