Fix -Wundef error and dead Hexagon guard in xnnpack.h - #11141
Merged
copybara-service[bot] merged 1 commit intoSep 7, 2026
Conversation
Consumers compiling the public header with -Wundef -Werror fail on any architecture: error: 'XNN_ARCH_HEXAGON' is not defined, evaluates to 0 [-Werror,-Wundef] #if XNN_ARCH_HEXAGON XNN_ARCH_HEXAGON is defined only in src/xnnpack/common.h, an internal header xnnpack.h cannot include, so the guard tested an undefined macro and the 128-byte value never took effect. HVX vectors are 1024-bit: a full-width load can read up to 128 bytes past a tensor callers padded by 16. Deriving from __hexagon__ keeps the internal header internal, and both definitions expand identically so neither redefinition warns.
qukhan
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers compiling the public header with -Wundef -Werror fail on any architecture:
error: 'XNN_ARCH_HEXAGON' is not defined, evaluates to 0
[-Werror,-Wundef] #if XNN_ARCH_HEXAGON
XNN_ARCH_HEXAGON is defined only in src/xnnpack/common.h, an internal header xnnpack.h cannot include, so the guard tested an undefined macro and the 128-byte value never took effect. HVX vectors are 1024-bit: a full-width load can read up to 128 bytes past a tensor callers padded by 16.
Deriving from hexagon keeps the internal header internal, and both definitions expand identically so neither redefinition warns.