[Security] Fix integer overflow in slice-nd reshape strides - #11132
Open
roopd3v wants to merge 1 commit into
Open
[Security] Fix integer overflow in slice-nd reshape strides#11132roopd3v wants to merge 1 commit into
roopd3v wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
roopd3v
force-pushed
the
fix/slice-nd-stride-overflow
branch
from
September 3, 2026 21:42
4e1a642 to
aa64c5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reshape_slice_nd()builds input/output strides with unguardedsize_tmultiplies. On overflow the stored strides wrap, so setup can advance the input pointer past a buffer sized from the wrapping product of the same dims.This applies
xnn_safe_mul()and returnsxnn_status_invalid_parameteron overflow, matching the depth-to-space hardening in PR #10990.Reported privately via Google OSS VRP; opening this PR at the program's request so the merged-patch acceptance criterion can be met.