Repository navigation
feat(gooddata-eval): per-trace latency percentiles and a restyled HTML report #1866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JanBran
wants to merge
10
commits into
gooddata:master
Choose a base branch
from
JanBran:jb/eval-report-latency-percentiles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
74f90fe
feat(gooddata-eval): record per-run latency and report percentiles
f135615
feat(gooddata-eval): restyle HTML report, show latency percentiles
f1ba69e
feat(gooddata-eval): split latency by single-shot vs multi-turn
f568084
feat(gooddata-eval): label item latency, multi-select kind filter
cfe3c69
feat(gooddata-eval): filters on top drive the whole HTML report
515c384
feat(gooddata-eval): two filter tiers, multi-select status and run
8ebedf0
feat(gooddata-eval): add a trimmed mean to the latency distributions
60dad1e
feat(gooddata-eval): redesign the HTML report as a readable document
1054889
Merge upstream master into jb/eval-report-latency-percentiles
7bc56fa
fix(gooddata-eval): count timed-out turns and fix HTML change labels
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Medium: on the generic
except Exceptionbranch,finallystill keeps the trace latencies collected so far, but the item getsruns = 0and norun_latencies_s. A multi-turn item that completes 2 of 3 runs and then raises keeps its turns inmulti_turn.traces_sbut contributes nothing toruns_s. The per-response and per-conversation tables then cover different item sets, and the row shows a response time with–for time per attempt.Either apply
_apply_run_latencieshere too (if the exception carries them) or drop the traces for items that report no runs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7bc56fa, by dropping the traces rather than applying the run latencies.
Applying
_apply_run_latencieshere wouldn't fix the case you describe: an exception raised in the middle of run 3 doesn't carry the times of runs 1 and 2, only the assertion and judge errors do, and those are handled by the branches above. So the generic branch now callstraces.discard()(newTraceRecorder.discard), and an item that reports no runs contributes to neither the per-response nor the per-conversation table.I replaced the test that deliberately kept those traces. An ungraded item (judge fault) still keeps both, since its run times are on the exception, and there's a test for that too.