Repository navigation
[bot] Merge master/98aadca5 into rel/dev - #1859
Merged
Merged
Conversation
`uv audit` reported 46 advisories in pyjwt, urllib3, virtualenv, werkzeug, sh and wasmtime. This fixes all that can be fixed from this repo; sh (pinned to 1.x by gitlint) and wasmtime (no fix released, comes via gooddata-code-convertors) remain. User-facing changes: - gooddata-api-client now requires urllib3 >=2.8.0 (was >=2.6.1), fixing HTTPS proxy TLS config being ignored, a chunked deflate infinite loop and unbounded chunk-size line buffering. - gooddata-api-client now requires Python >=3.10 (was >=3.6). urllib3 2.7+ dropped Python 3.9, so the old marker was no longer accurate. - gooddata-sdk now requires python-dotenv >=1.2.2 (was >=1.0.0). - gooddata-pipelines now requires requests >=2.33.0 (was >=2.32.3). - Behavior change when connecting through an HTTPS proxy (an `https://` proxy URL): urllib3 2.8 no longer applies the destination TLS settings (`ssl_ca_cert`, `cert_file`, `key_file`) to the TLS handshake with the proxy itself. If the proxy certificate was trusted only through `ssl_ca_cert`, add its CA to the system trust store. Plain `http://` proxies and direct connections are unaffected. - Environments where another package caps urllib3 below 2.8 will now report a dependency conflict at install time. Internal: test-group urllib3 pins move to `~=2.8`; lock upgrades for pyjwt 2.15.1 (via msal/azure-identity in pipelines), virtualenv 21.14.5 and werkzeug 3.1.9. The urllib3 and Python requirements are changed in the openapi-generator templates too so regeneration keeps them.
pytest 9 adds native `[tool.pytest]` TOML config and a single `strict` switch that turns on strict_markers, strict_config, strict_xfail and strict_parametrization_ids. Enable it in every package so unregistered marks, unknown config keys, unexpectedly passing xfails and duplicate parametrize ids fail instead of warning. Fixes needed to pass: - test_indexed_dataframe.py: `"region"` appears twice in index_types (once as a columns key, once as a label id), producing ids region0 and region1. Cases now carry explicit, descriptive ids. - test_catalog_user_service.py: drop two `pytest.mark.dependency` marks. pytest-dependency is not installed and nothing uses `depends=`, so they only produced PytestUnknownMarkWarning.
build: fix dependency advisories and enable pytest strict mode
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1859 +/- ##
========================================
Coverage 84.19% 84.19%
========================================
Files 333 333
Lines 23261 23261
========================================
Hits 19585 19585
Misses 3676 3676 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 98aadca (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/37746364584).