Repository navigation
internal/gcimporter: restore logical line numbers for cgo exports - #708
Open
Aghayenoor wants to merge 3 commits into
Open
Aghayenoor wants to merge 3 commits into
Aghayenoor wants to merge 3 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
This PR (HEAD: 66bee2c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/860501. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode line directive offsets in unified export data so that imported
objects point to their original cgo source lines. Keep high line
numbers in fixed-size synthetic file ranges that share a line table.
Add a go/packages regression test for cgo declarations at an ordinary
source line and at lines 70000 and 70001, in module and GOPATH mode.
Tests passed with Go 1.27.3 for go/packages, internal/gcimporter, and
go/gcexportdata.
Fixes golang/go#74037