Repository navigation
Conversation
Contributor
|
This PR (HEAD: d52792a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/858103. Important tips:
|
Contributor
|
Message from Alan Donovan: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/858103. |
gopherbot
pushed a commit
that referenced
this pull request
Nov 3, 2026
CL 774381 made -listen and -mcp.listen reject addresses like ":12345", but -debug still passes them straight to net.Listen, so -debug=:PORT exposes the unauthenticated debug server on all interfaces. Reject an implicit host for -debug in gopls serve, with the same error as -listen, and in debug.Instance.Serve, which also covers the gopls.start_debugging command. Update the docs that suggested ":0". + relnote Fixes golang/go#82821 Change-Id: Iad54533060846f891eb2e594d34393f1da20f4f2 GitHub-Last-Rev: d52792a GitHub-Pull-Request: #706 Reviewed-on: https://go-review.googlesource.com/c/tools/+/858103 Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Alex Putman <aputman@golang.org> Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Contributor
|
This PR is being closed because golang.org/cl/858103 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CL 774381 made -listen and -mcp.listen reject addresses like ":12345",
but -debug still passes them straight to net.Listen, so -debug=:PORT
exposes the unauthenticated debug server on all interfaces.
Reject an implicit host for -debug in gopls serve, with the same error
as -listen, and in debug.Instance.Serve, which also covers the
gopls.start_debugging command. Update the docs that suggested ":0".
Fixes golang/go#82821