Skip to content

gopls/internal/debug: reject implicit INADDR_ANY in debug address - #706

Closed
lazerg wants to merge 2 commits into
golang:masterfrom
lazerg:fix-debug-implicit-host
Closed

lazerg wants to merge 2 commits into
golang:masterfrom
lazerg:fix-debug-implicit-host

Conversation

@lazerg

@lazerg lazerg commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

CL 774381 made -listen and -mcp.listen reject addresses like ":12345",
but -debug still passes them straight to net.Listen, so -debug=:PORT
exposes the unauthenticated debug server on all interfaces.

Reject an implicit host for -debug in gopls serve, with the same error
as -listen, and in debug.Instance.Serve, which also covers the
gopls.start_debugging command. Update the docs that suggested ":0".

  • relnote

Fixes golang/go#82821

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: d52792a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/858103.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Alan Donovan:

Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/858103.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 3, 2026
CL 774381 made -listen and -mcp.listen reject addresses like ":12345",
but -debug still passes them straight to net.Listen, so -debug=:PORT
exposes the unauthenticated debug server on all interfaces.

Reject an implicit host for -debug in gopls serve, with the same error
as -listen, and in debug.Instance.Serve, which also covers the
gopls.start_debugging command. Update the docs that suggested ":0".

+ relnote

Fixes golang/go#82821

Change-Id: Iad54533060846f891eb2e594d34393f1da20f4f2
GitHub-Last-Rev: d52792a
GitHub-Pull-Request: #706
Reviewed-on: https://go-review.googlesource.com/c/tools/+/858103
Reviewed-by: Alan Donovan <adonovan@google.com>
Reviewed-by: Alex Putman <aputman@golang.org>
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot

Copy link
Copy Markdown
Contributor

This PR is being closed because golang.org/cl/858103 has been merged.

@gopherbot gopherbot closed this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/tools/gopls: -debug=:PORT still binds 0.0.0.0 and exposes source (CVE-2026-42503 incomplete fix)

2 participants