go/analysis/passes/fieldalignment: skip structs with unkeyed literals by manish-9245 · Pull Request #703 · golang/tools

manish-9245 · 2026-10-23T08:28:09Z

The suggested fix reorders the fields of a struct declaration but
leaves unkeyed composite literals of that struct alone. The literal
then silently assigns values to the wrong fields, or no longer
compiles.

Do not report a struct that has an unkeyed composite literal in the
same package, as suggested in the issue. Unkeyed literals from other
packages are already a mistake, since reordering fields is a
compatible change.

Fixes golang/go#80277

google-cla · 2026-10-23T08:28:15Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2026-10-23T09:05:58Z

This PR (HEAD: bf559df) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/853065.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-10-23T09:50:02Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-23T19:05:19Z

Message from Madeline Kalil:

Patch Set 1: Commit-Queue+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-23T19:22:40Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-10-23T18:47:34Z","revision":"74c7373f79bc35900fe3d4907e63e668d67bc1b0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-23T19:22:41Z

Message from Madeline Kalil:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_3771561>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-23T19:22:42Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-386_debian13 has failed with summary (view all results):

go on master (commit a92a4e4) / tools on master (change 853065)

To reproduce, try gomote repro 8667126311449569809.

Additional links for debugging:

test golang.org/x/tools module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-23T19:22:43Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-25T05:30:40Z

This PR (HEAD: 2dbd95a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/853065.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-10-25T17:43:41Z

Message from Manish Tiwari:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-25T17:43:42Z

Message from Manish Tiwari:

Patch Set 2:

Thanks for the review. Patch set 2 addresses your three comments: the package doc now mentions that structs with an unkeyed composite literal in the same package are not reported, I added the note that checking the first element is enough, and I moved the comments as suggested. It also fixes the linux-386 failure: the test pattern hard-coded 64-bit sizes, so it now matches any size. Could you re-run the dry run when you have a moment?

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-25T18:59:22Z

Message from Peter Weinberger:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-25T19:16:17Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-10-25T18:43:38Z","revision":"b4732db62969dc031caa8777dabdd64378a17f4f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-25T19:16:18Z

Message from Peter Weinberger:

Patch Set 2: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_5260>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-25T19:16:18Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64-boringcrypto has failed with summary (view all results):

go on master (commit 0d37007) / tools on master (change 853065)

To reproduce, try gomote repro 8666945365758493873.

Additional links for debugging:

test golang.org/x/tools/gopls module output

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-25T19:16:19Z

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-10-27T15:00:51Z

Message from Madeline Kalil:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/853065.
After addressing review feedback, remember to publish your drafts!

The suggested fix reorders the fields of a struct declaration but leaves unkeyed composite literals of that struct alone. The literal then silently assigns values to the wrong fields, or no longer compiles. Do not report a struct that has an unkeyed composite literal in the same package, as suggested in the issue. Unkeyed literals from other packages are already a mistake, since reordering fields is a compatible change. Fixes golang/go#80277

gopherbot · 2026-10-31T07:14:16Z

This PR (HEAD: 4d5ff04) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/853065.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

manish-9245 force-pushed the fix-80277 branch from 8118401 to bf559df Compare October 23, 2026 08:35

manish-9245 force-pushed the fix-80277 branch from bf559df to 2dbd95a Compare October 25, 2026 05:18

manish-9245 force-pushed the fix-80277 branch from 2dbd95a to 4d5ff04 Compare October 31, 2026 07:13

Conversation

manish-9245 commented Oct 23, 2026

Uh oh!

google-cla Bot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 23, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 25, 2026

Uh oh!

gopherbot commented Oct 27, 2026

Uh oh!

gopherbot commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants