Skip to content

unix: add bounds checks to FdSet.Set, Clear, and IsSet - #297

Open
TristanInSec wants to merge 1 commit into
golang:masterfrom
TristanInSec:fix-fdset-bounds-check
Open

TristanInSec wants to merge 1 commit into
golang:masterfrom
TristanInSec:fix-fdset-bounds-check

Conversation

@TristanInSec

Copy link
Copy Markdown

FdSet.Set, Clear, and IsSet do not validate the fd parameter before indexing into fds.Bits, causing a runtime panic when fd >= FD_SETSIZE (1024) or fd < 0.

This adds bounds checks consistent with the CPUSet helpers in affinity_linux.go, which already guard against out-of-range indices via cpuBitsIndex checks.

Set and Clear silently return on out-of-range fd (matching CPUSet.Set/Clear behavior). IsSet returns false.

FdSet.Set, Clear, and IsSet do not validate the fd parameter
before indexing into fds.Bits, causing a runtime panic when
fd >= FD_SETSIZE (1024) or fd < 0.

Add bounds checks consistent with the CPUSet helpers in
affinity_linux.go, which already guard against out-of-range
indices.
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 7e9ca6f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/857701.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/857701.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/857701.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants