Skip to content

fix: clean up incorrect CLI log output usage - #953

Merged
bupd merged 3 commits into
goharbor:mainfrom
rakshityadav1868:log-output-cleanup
Aug 7, 2026
Merged

fix: clean up incorrect CLI log output usage#953
bupd merged 3 commits into
goharbor:mainfrom
rakshityadav1868:log-output-cleanup

Conversation

@rakshityadav1868

Copy link
Copy Markdown
Contributor

Description

This PR cleans up a few incorrect or redundant log/output usages identified during the logging audit.

The changes focus on separating user-facing CLI output from internal/debug logging and removing accidental debug artifacts from stdout.

Type of Change

Please select the relevant type.

  • Refactor
  • Chore / maintenance

Changes

  • Removed redundant debug log from project delete flow
  • Replaced user-facing log.Println(...) usage with fmt.Println(...)
  • Removed accidental debug artifact printing raw table column data
  • Removed internal replication policy state dump from stdout

Verification

  • go build ./...
  • go vet ./...

Signed-off-by: Rakshit Yadav <yadavrakshit60@gmail.com>
Comment thread cmd/harbor/root/project/member/delete.go
…put change

Signed-off-by: Rakshit Yadav <yadavrakshit60@gmail.com>

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 9.77%. Comparing base (60ad0bd) to head (e4fc110).
⚠️ Report is 206 commits behind head on main.

Files with missing lines Patch % Lines
cmd/harbor/root/project/member/delete.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             main    #953      +/-   ##
=========================================
- Coverage   10.99%   9.77%   -1.22%     
=========================================
  Files         173     322     +149     
  Lines        8671   16174    +7503     
=========================================
+ Hits          953    1581     +628     
- Misses       7612   14459    +6847     
- Partials      106     134      +28     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bupd bupd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bupd
bupd merged commit 05fefba into goharbor:main Aug 7, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants