fix(retention): use resolved retention ID when deleting rules - #1081
Open
yash-pakhale-07 wants to merge 1 commit into
Open
fix(retention): use resolved retention ID when deleting rules#1081yash-pakhale-07 wants to merge 1 commit into
yash-pakhale-07 wants to merge 1 commit into
Conversation
Signed-off-by: yash-pakhale-07 <yashpakhale7@gmail.com>
yash-pakhale-07
force-pushed
the
fix/tag-retention-delete-project-id
branch
from
August 12, 2026 04:15
35eb05e to
30ee067
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the tag retention deletion flow when a project is specified using
--project-id.The CLI already resolves the retention policy ID, but the resolved ID was discarded and
DeleteRetention()was called with the project name. The API layer then performed another project-name-based lookup.This change passes the resolved retention ID directly through the deletion flow.
Fixes #1080
Type of Change
Changes
retentionIDtoapi.DeleteRetention().DeleteRetention()to accept the retention ID directly.GetRetentionId()lookup from the API deletion path.