Bubbletea v1 to v2 migration - #1076
Conversation
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
=========================================
- Coverage 10.99% 9.58% -1.41%
=========================================
Files 173 322 +149
Lines 8671 16165 +7494
=========================================
+ Hits 953 1549 +596
- Misses 7612 14481 +6869
- Partials 106 135 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Nishchay Rajput <nishchayr@iitbhilai.ac.in>
|
@NishchayRajput Thank you for taking this on. The mechanical migration looks consistent, and moving alt screen into the view state is exactly how v2 intends it. Testing against the demo Harbor instance surfaced two regressions, both in shared base views (so two fixes cover all call sites). Both have the same root cause: v2 clips to the terminal cell buffer, while v1 flushed the final frame regardless of size.
For verification, one command per base class covers everything: Follow-up material, fine to defer: |
Description
Briefly describe what this pull request does and why the change is needed.
The goal is to preserve current Harbor CLI behavior while aligning the codebase with the Charm v2 ecosystem.
The migration affects four main areas:
Type of Change
Please select the relevant type.
Changes