ci: run ./adaptive/... in its own job, and make the up-switch tests skip with a reason (#641) - #660
Merged
Merged
Conversation
…kip with a reason (#641) [control arm] CONTROL ARM. This commit adds the job WITHOUT raising memlock, so on a GitHub-hosted runner (8 MiB) adaptive.New disables the up-switch and the five tests gated by requireUpSwitch must FAIL with "CELERIS_REQUIRE_UPSWITCH=1 forbids skipping". The next commit raises memlock and must turn them green. This proves the gate bites before it is trusted.
…#641) The previous commit ran the job at the runner's default memlock and the five up-switch tests failed with "CELERIS_REQUIRE_UPSWITCH=1 forbids skipping", which proves the gate bites. Raising the step shell's limit (inherited by the test processes) lets adaptive.New enable the switch, so they run for real.
…s fixed (#641) celeris#661 fixed the lost hand-off wakeup behind the test's fd leak; the churn test passed 10/10 at both memlock limits on the fix. It runs again.
FumingPower3925
force-pushed
the
ci/641-run-adaptive-package
branch
from
September 15, 2026 17:51
c55eebb to
82a6850
Compare
…s#662 (#641) On two GitHub-runner runs of this job (c55eebb and 82a6850, memlock unlimited) both tests lost about a third of their 2048 connections at each promotion to "connection reset by peer" / unexpected EOF, and the controller's error-rate safety revert then flapped the engine. celeris#662 reproduces the cause deterministically: PauseAccept drops the connections already queued on the paused engine (EOF 8/8 with a pause, 200 8/8 without). The other three up-switch tests still run and pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #641.
What changes
adaptivejob runs./adaptive/..., the default engine's package, which no CI job ran before. It raises memlock withsudo prlimit --pid "$$" --memlock=unlimited:unlimitedand setsCELERIS_REQUIRE_UPSWITCH=1.requireUpSwitchgates the five tests whose claim is the conns-per-worker up-switch. Whereadaptive.Newdisables the switch (memlock below one worker's rings), they skip and say why instead of running to their bound and failing.CELERIS_REQUIRE_UPSWITCH=1turns that skip into a failure, so this job cannot go green by skipping them.-skipentry when its issue closes.TestBidirectionalFlapAsync: adaptive: forced switches leave keep-alive connections behind — async conns miss the 1.2 s flap window in every run, and a one-worker io_uring strands sync conns until their requests fail #657TestRampH1SyncandTestRampH1Async: epoll: PauseAccept silently drops connections already waiting in the accept queue — their requests get EOF (8/8, deterministic), and a promotion on a GitHub runner loses ~1/3 of 2048 connections #662. On a GitHub runner, a promotion drops the connections queued on the paused engine, about a third of 2048.TestAdaptiveSwitchVsAcceptChurnruns again. Its fd leak, adaptive: TestAdaptiveSwitchVsAcceptChurn kept 307 file descriptors over baseline after its settle in 1 of 3 runs — what leaked is not recorded #658, was fixed by fix(engine): wake a parked standby for the connection it was handed, and close adoptions still queued at shutdown (celeris#658) #661.Proven on GitHub-hosted runners
70a4abf(control arm)CELERIS_REQUIRE_UPSWITCH=1 forbids skipping, plus the known one-workerTestReverseTransplantflakec55eebbTestRampH1Sync/TestRampH1Asynclose ~1/3 of 2048 conns toconnection reset by peer82a6850(on mainc40d0cb)456f0e6TestRampAutoMixedH1H2,TestRampAutoMixedAsync,TestAdaptiveSwitchesWithPreBoundListener,TestAdaptiveSwitchVsAcceptChurn,TestReverseTransplant,TestBidirectionalFlapall PASS; 0 FAIL, 0 racesThe control arm is recorded as a deliberate red run.
Not in this PR
Adaptive engine (./adaptive/...)becomes one is the repository owner's decision; it is not yet required.