fix: recover text tool-calls and keep transient noise out of history#119
Merged
Conversation
jbj338033
force-pushed
the
worktree-llm-idiot
branch
from
July 14, 2026 00:31
65bd7bb to
2f1ca87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Transient model/runtime anomalies — a tool call emitted as plain text, a machine status line, an empty reasoning block — were persisted verbatim into the conversation and re-sent, so a one-off error became a self-reinforcing, cache-amplified failure that even a direct human correction could not overcome. This makes the harness robust to those anomalies:
<invoke>/antml:universal, Hermes/Mistral for local models) in a newtool_recoverymodule.Verification
cargo fmt --all --check— passedcargo clippy --workspace --all-targets -- -D warnings— passedcargo test --workspace— passed (goat-agent 125, incl. 13 tool_recovery unit tests over the real leaked sample and local dialects)