fix interrupt latency and process-wake double turns#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two turn-lifecycle bugs plus the surrounding cleanup they exposed. Interrupts were ignored while a turn was parked in
provider.stream(request).await(HTTP send + time-to-first-token), so pressing Esc did nothing until the request returned. And a watched background process re-woke the agent with a(process activity)turn even when the agent had already consumed that output/exit itself, because the read cursor and the watch cursor were tracked separately.provider.stream()open againsttoken.cancelled()inrun_round/compaction so cancellation drops the in-flight request immediately.read_cursor/watch_cursorinto oneseen_cursorand mark exit observed on read, so output already read viaProcessOutputnever wakes a fresh turn; clarify thewatchtool docs.tokio::sync::Notify, sharenow_ms/truncate_chars, extract the triplicated mid-turn op pump, droptop_regime's constant sandbox tuple.Verification
cargo fmt --all --check— passedcargo clippy -p goat-agent -p goat-tool --all-targets -- -D warnings— passedcargo test -p goat-agent -p goat-tool— passed (113 + 31)