Repository navigation
Cascade merge: 4.x into master - #262
Merged
Merged
Conversation
…mespace ReflectionMethod::getAttributes() failed for unqualified constants (true, false, null, PHP_INT_MAX, namespaced constants): NodeExpressionResolver looked them up in the namespace of the method itself, which is always '' (like the native reflection), so ReflectionFileNamespace threw "Namespace was not found" (or a ValueError for an empty path when the method was reflected on its own and had no file name). The resolver now takes the namespace and the file from the reflector that owns the code: the declaring class for methods, properties and class constants (the trait for imported trait methods), the declaring function or class for parameters. This also makes __NAMESPACE__, __FILE__ and __DIR__ work in these contexts, and skips the namespace lookup for true/false/null (case-insensitively) and for code without a file. Fixes #259 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1GTbduntXjyF8E9Feb
fix: Resolve constants in attributes of class members in the class namespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cascade merge that keeps
masterin sync with the4.xmaintenance branch.This PR tracks
4.xand merges automatically once required checks pass, when auto-merge is allowed for the repository; otherwise merge it manually. A new one is opened after each merge, so every future push to4.xkeeps flowing forward intomaster.If this PR shows a conflict, resolve it manually on
4.x(or directly on this PR's branch) — auto-merge will pick it up once it's clean again.