Repository navigation
Cascade merge: 4.x into master - #255
Merged
Merged
Conversation
A partial reflection left a missing parent class and missing interfaces out of every API, so a consumer that needs their names (a proxy generator re-declaring extends/implements, for instance) had to read them from the AST node itself. - ReflectionClass::getParentClassName() returns the name of the parent class as written in the source, located or not, without reflecting it; - getInterfaceNames() and implementsInterface() of a partial reflection include the missing interfaces declared by the class and by its available ancestors. getInterfaces() still lists the located ones only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
Review feedback: the declared names of the parent class and interfaces were read by static ReflectionClass::getDeclaredParentName() and getDeclaredInterfaceNames(), next to getParentClassName() and getInterfaceNames() doing the same job. - the static helpers are removed; one private instance method of the trait, getAncestorNamesFromSource(), reads the parent class, interfaces and traits from $this->classLikeNode, and getParentClassName(), getParentClass(), getInterfaceNames(), getTraitNames() and getMissingClassNames() use it; - getTraitNames() of a partial reflection names the missing traits too, like getInterfaceNames() does for interfaces; - ReflectionClass::collectMissingAncestorNames(), released in 4.1, is kept as a deprecated wrapper of getMissingClassNames(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
PHPStan does not apply a docblock above a closure assignment to its parameters, so the name nodes were mixed: check them with instanceof. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
It was added in 4.1 and is hardly used yet: getMissingClassNames() of the reflection replaces it, no deprecated wrapper is kept (review feedback). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
feat: Name missing ancestors of a partial reflection as written in the source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cascade merge that keeps
masterin sync with the4.xmaintenance branch.This PR tracks
4.xand merges automatically once required checks pass. A new one is opened after each merge, so every future push to4.xkeeps flowing forward intomaster.If this PR shows a conflict, resolve it manually on
4.x(or directly on this PR's branch) — auto-merge will pick it up once it's clean again.