Repository navigation
Name missing ancestors of a partial reflection as written in the source - #254
Merged
Merged
Conversation
A partial reflection left a missing parent class and missing interfaces out of every API, so a consumer that needs their names (a proxy generator re-declaring extends/implements, for instance) had to read them from the AST node itself. - ReflectionClass::getParentClassName() returns the name of the parent class as written in the source, located or not, without reflecting it; - getInterfaceNames() and implementsInterface() of a partial reflection include the missing interfaces declared by the class and by its available ancestors. getInterfaces() still lists the located ones only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
lisachenko
commented
Nov 3, 2026
Review feedback: the declared names of the parent class and interfaces were read by static ReflectionClass::getDeclaredParentName() and getDeclaredInterfaceNames(), next to getParentClassName() and getInterfaceNames() doing the same job. - the static helpers are removed; one private instance method of the trait, getAncestorNamesFromSource(), reads the parent class, interfaces and traits from $this->classLikeNode, and getParentClassName(), getParentClass(), getInterfaceNames(), getTraitNames() and getMissingClassNames() use it; - getTraitNames() of a partial reflection names the missing traits too, like getInterfaceNames() does for interfaces; - ReflectionClass::collectMissingAncestorNames(), released in 4.1, is kept as a deprecated wrapper of getMissingClassNames(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
PHPStan does not apply a docblock above a closure assignment to its parameters, so the name nodes were mixed: check them with instanceof. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
lisachenko
commented
Nov 3, 2026
It was added in 4.1 and is hardly used yet: getMissingClassNames() of the reflection replaces it, no deprecated wrapper is kept (review feedback). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
4 tasks done
lisachenko
marked this pull request as ready for review
November 3, 2026 16:56
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #251 / #252, needed by goaop/framework#788 (review: the framework must not read parser-reflection's AST to recover the names of missing ancestors).
Problem
A partial reflection (
MissingAncestorPolicy::Partial) left a missing parent class, interfaces and traits out of every API, even though their names are known from the source. A consumer that needs those names, such as the framework's proxy generator re-declaringextends/implements, had to resolve them fromgetNode()itself.Change
ReflectionClass::getParentClassName(): string|false(also onReflectionEnum, through the trait): returns the name of the parent class as written in the source, located or not, without reflecting it. It returnsfalsewhen the class declares no parent.getParentClass()now uses it too.getInterfaceNames()includes the missing interfaces declared by the class and by its available ancestors (for example, a missing interface of the parent class is named through the parent).implementsInterface()agrees with it.getTraitNames()includes the missing traits the class uses.getInterfaces()andgetTraits()still list only the ancestors that were located.getAncestorNamesFromSource(), reads the parent class, interfaces and traits from$this->classLikeNode.getParentClassName(),getInterfaceNames(),getTraitNames()andgetMissingClassNames()all use it, and nothing new is added to the public static API.ReflectionClass::collectMissingAncestorNames(), added in 4.1 and hardly used yet, is removed:getMissingClassNames()of the reflection replaces it.This changes behaviour released in 4.1 / 5.1: a partial reflection's
getInterfaceNames()andgetTraitNames()used to leave missing ancestors out. #251 asked for "the names of the parent, interfaces and traits as written" to stay available, so this aligns with the issue.Tests
PartialReflectionTest:getParentClassName()returns the missing parent, a located parent andfalse, under both policies;getInterfaceNames()/implementsInterface()/getTraitNames()include the missing ancestors for the class, for a child of a partial class and for an interface extending a missing one, whilegetInterfaces()/getTraits()still list only the located ones.vendor/bin/phpunit: 13,765 tests pass. Skipped and incomplete counts are unchanged.Docs
The README's partial reflection section,
docs/reflection_class.mdandCLAUDE.mdare updated.🤖 Generated with Claude Code
https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL