Repository navigation
Cascade merge: 4.x into master - #253
Merged
Merged
Conversation
Reflecting a class requires its parent class, interfaces and traits. When the locator could not find one of them, every method that needs it threw, so the class could not be reflected at all, even for its own methods. ReflectionEngine now takes a MissingAncestorPolicy (via init() or setMissingAncestorPolicy()): - Strict (default): the current behaviour, a ClassNotFoundException (which extends InvalidArgumentException) is thrown; - Partial: missing ancestors are left out, and the reflection covers what the class and its available ancestors declare. ReflectionClass and ReflectionEnum gain isPartial() and getMissingClassNames(), which report missing ancestors transitively and never throw, whatever the policy. All ancestor reflections now go through ReflectionClass::reflectAncestor(). Closes #251 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
Passing the result of class_exists() and alike as a bool lost the narrowing of the ancestor name to a class-string, so PHPStan rejected the native reflection of a declared ancestor. The helper now checks it itself, as ReflectionEngine::locateClassFile() does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FxhC1CBg4rnTu9UjAMcCpL
feat: Partial reflection of classes whose ancestors can not be located
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated cascade merge that keeps
masterin sync with the4.xmaintenance branch.This PR tracks
4.xand merges automatically once required checks pass. A new one is opened after each merge, so every future push to4.xkeeps flowing forward intomaster.If this PR shows a conflict, resolve it manually on
4.x(or directly on this PR's branch) — auto-merge will pick it up once it's clean again.