Give the README a banner that matches goa.design - #3992
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the README's white, single-layout banner with artwork that matches goa.design: Manrope typography, a navy/blue palette, the two-line headline, and the original round Goa badge. The desktop image shows one contract generating HTTP, gRPC, and JSON-RPC; the mobile layout keeps the headline and transport names readable.
The README uses GitHub's
#gh-light-mode-onlyand#gh-dark-mode-onlylink markers to select the theme. Each link contains apictureelement that selects a mobile PNG by viewport width, falling back to that theme's desktop PNG. Theme selection and width queries are separate because GitHub'sthemed-picturecomponent replaces theme media queries and discards their width conditions.The image's alternative text describes the headline and transport scope. Only the first banner block changes; the rest of the README, including the release badge, examples, sponsors, and links, is byte-for-byte unchanged.
The artwork is authored in goadesign/goa.design's
scripts/readme-banner.htmland regenerated withmake readme-banner; all four PNGs are copied unchanged from that source. No application code, dependencies, or public APIs change. No migration or coordinated deployment is needed; reverting this commit restores the previous banner.Validation:
themed-picturecomponent selects exactly one correct image across all 12 combinations of light/dark/automatic GitHub mode, light/dark system theme, and desktop/phone width, without article overflow.