Skip to content

start v1.11 development - #1803

Merged
methane merged 2 commits into
go-sql-driver:masterfrom
methane:start-v1.11
Sep 2, 2026
Merged

methane merged 2 commits into
go-sql-driver:masterfrom
methane:start-v1.11

Conversation

@methane

@methane methane commented Sep 2, 2026

Copy link
Copy Markdown
Member

Update Go, MySQL, and MariaDB versions.

Update Go, MySQL, and MariaDB versions.
@methane
methane requested a balanced review from Copilot September 2, 2026 09:32
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: bc4cb2dd-af84-4bc9-b14a-493551aca5ff

📥 Commits

Reviewing files that changed from the base of the PR and between 7ca26e8 and 0e7e1bf.

⛔ Files ignored due to path filters (2)
  • .github/workflows/test.yml is excluded by !**/*.yml
  • go.mod is excluded by !**/*.mod
📒 Files selected for processing (1)
  • README.md

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


Walkthrough

The README Requirements section now requires Go 1.25 or higher and lists MySQL 8.0+ and MariaDB 10.11+ as maintainer-supported versions.

Changes

Requirements documentation

Layer / File(s) Summary
Update supported versions
README.md
The Requirements section raises the minimum Go version to 1.25 and updates the supported MySQL and MariaDB versions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0e7e1

This PR updates supported Go, MySQL, and MariaDB versions without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

Suggested reviewers: milanobrtlik

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title identifies the v1.11 development work. It is broad, but it is directly related to the version updates in the changeset.
Description check ✅ Passed The description directly states that the pull request updates the Go, MySQL, and MariaDB versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The version policy and CI matrix align, with only a non-blocking documentation correction suggested.

Pull request overview

Raises supported Go and database versions for v1.11 development.

Changes:

  • Requires Go 1.25 and tests Go 1.25–1.27.
  • Updates supported MySQL/MariaDB versions.
  • Refreshes the CI database matrix.
File summaries
File Description
README.md Documents new minimum versions.
go.mod Sets Go 1.25 as the module minimum.
.github/workflows/test.yml Updates CI versions; one inaccurate comment was flagged.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

mysql = [
'9.0',
'8.4', # LTS
mysql = [ # LTS versions
@coveralls

coveralls commented Sep 2, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 84.211% (+1.6%) from 82.642% — methane:start-v1.11 into go-sql-driver:master

@methane
methane merged commit ade1edb into go-sql-driver:master Sep 2, 2026
26 checks passed
@methane
methane deleted the start-v1.11 branch September 2, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants