Conversation
… and support for seeding JWKS from storage
… and utilize jsonv2 experiment
…87) including key generation, PEM encoding/decoding, and signing/verification
…er algorithm abstraction
Contributor
 |
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage  |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
Jul 20, 2026 8:48a.m. | Review ↗ |
| Code coverage | |
Jul 20, 2026 8:48a.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 49.3% |
49.8% [▲ up 4.6% from main] |
| Go | 49.3% |
49.8% [▲ up 4.6% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
In rotationStep, the rotation-evaluation loop over kms.Algs ran before pending scheduled algorithm/default changes were applied. After a scheduled alg switch became effective and the old alg's key had expired (e.g. during downtime), the loop still iterated the old alg set and regenerated a key for the no-longer-configured algorithm. Move the scheduled-state application (applyAlg/applyDef) to run before the rotation-evaluation loop, and re-fetch active keys afterwards so the loop operates on the up-to-date alg set and loaded keys. Also derive the sleep wait from the injected 'now' instead of time.Until for consistency. Applies to both PEMStorageKMS and PKCS11KMS. Adds a regression test.
…and validations Introducing `SubordinateJWKSRefresher`, which automates subordinate JWKS polling and updates, ensuring changes are detected and updated in storage. Includes tests for key scenarios like signature verification, polling intervals, and KID conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.