Skip to content

README.md: remove reference to Replier - #37

Merged
zchee merged 3 commits into
go-language-server:mainfrom
nelsam:nelsam/replier-docs
Aug 31, 2026
Merged

zchee merged 3 commits into
go-language-server:mainfrom
nelsam:nelsam/replier-docs

Conversation

@nelsam

@nelsam nelsam commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

As of a685e84, the Replier no longer exists. Including it in the README is confusing. This updates the README to reference the modern Handler type.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the example handler signature in the README.md to return a result and an error directly, rather than using a Replier. The review feedback correctly notes that the surrounding explanatory text in the README should also be updated to reflect this change.

Comment thread README.md
As of a685e84, the Replier no longer
exists. Including it in the README is confusing. This updates the
README to reference the modern Handler type.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project README to reflect the current server-side API by removing the obsolete Replier reference and documenting the direct-return Handler shape used by HandlerServer/Serve.

Changes:

  • Reworded the HandlerServer + Serve section to describe direct-return request handling.
  • Updated the server example handler signature and return style to match the modern Handler type.
Suppressed comments (2)

README.md:144

  • This example comment still refers to “reply”, but the Handler API is now direct-return. Updating the wording will keep the example consistent with the API.
		// Decode params, do work, reply with a typed result.

README.md:149

  • In the direct-return Handler contract, returning a non-nil error for a notification fails the connection. As written, an unknown notification method would close the connection; the example should drop unknown notifications and only return ErrMethodNotFound for calls (similar to MethodNotFoundHandler).
	default:
		// Answer unknown calls with the standard error.
		return nil, jsonrpc2.ErrMethodNotFound
	}

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Outdated

@zchee zchee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First approve for CI

Comment thread README.md Outdated
@zchee zchee self-assigned this Aug 31, 2026
@zchee

zchee commented Aug 31, 2026

Copy link
Copy Markdown
Member

@nelsam Temporarily close to trigger the CI process.

@zchee zchee closed this Aug 31, 2026
@zchee zchee reopened this Aug 31, 2026
@codecov

codecov Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (a1c1575) to head (f8c3352).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

@@          Coverage Diff          @@
##            main     #37   +/-   ##
=====================================
  Coverage   82.0%   82.1%           
=====================================
  Files         29      29           
  Lines       4100    4100           
=====================================
+ Hits        3366    3367    +1     
+ Misses       734     733    -1     
Flag Coverage Δ
Linux-ARM64 82.0% <ø> (ø)
Linux-X64 84.6% <ø> (+<0.1%) ⬆️
see 1 file with indirect coverage changes

@zchee

zchee commented Aug 31, 2026

Copy link
Copy Markdown
Member

Okay, CI has fired.

@zchee zchee closed this Aug 31, 2026
@zchee zchee reopened this Aug 31, 2026

This comment was marked as low quality.

@zchee
zchee force-pushed the nelsam/replier-docs branch from 2582438 to 642d0fa Compare August 31, 2026 12:59
Co-authored-by: GitHub Copilot <198982749+Copilot@users.noreply.github.com>
@zchee
zchee force-pushed the nelsam/replier-docs branch from 642d0fa to f8c3352 Compare August 31, 2026 13:00
@zchee
zchee merged commit f8c3352 into go-language-server:main Aug 31, 2026
9 checks passed
@zchee

zchee commented Aug 31, 2026

Copy link
Copy Markdown
Member

@nelsam applied f8c3352 and merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants