Skip to content

feat: add goleak, guard InitRollbar on empty token #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankurs merged 2 commits into from
Apr 9, 2026
Merged

feat: add goleak, guard InitRollbar on empty token #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28c1d97
feat: add goleak test coverage, guard InitRollbar on empty token
ankurs Apr 9, 2026
bf9fb98
fix: reset rollbarInited on empty token, bump Go to 1.25.9
ankurs Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/go-coldbrew/errors

go 1.25.8
go 1.25.9
Comment thread
ankurs marked this conversation as resolved.

require (
github.com/airbrake/gobrake/v5 v5.6.2
Expand All @@ -12,6 +12,7 @@ require (
go.opentelemetry.io/otel v1.43.0
go.opentelemetry.io/otel/sdk v1.43.0
go.opentelemetry.io/otel/trace v1.43.0
go.uber.org/goleak v1.3.0
google.golang.org/grpc v1.79.3
)

Expand Down
11 changes: 11 additions & 0 deletions goleak_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package errors

import (
"testing"

"go.uber.org/goleak"
)

func TestMain(m *testing.M) {
goleak.VerifyTestMain(m)
}
Comment thread
ankurs marked this conversation as resolved.
4 changes: 4 additions & 0 deletions notifier/notifier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ func InitAirbrake(projectID int64, projectKey string) {
// token: rollbar token
// env: rollbar environment
func InitRollbar(token, env string) {
if token == "" {
Comment thread
ankurs marked this conversation as resolved.
rollbarInited = false
return
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
rollbar.SetToken(token)
rollbar.SetEnvironment(env)
rollbar.SetStackTracer(func(err error) ([]runtime.Frame, bool) {
Expand Down
Loading