fix segfault caused by memory allocated in one pool and freed in another#533
Open
jp-embedded wants to merge 1 commit intogittup:masterfrom
Open
fix segfault caused by memory allocated in one pool and freed in another#533jp-embedded wants to merge 1 commit intogittup:masterfrom
jp-embedded wants to merge 1 commit intogittup:masterfrom
Conversation
jp-embedded
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On large projects tup ends up in a segfault because mem_pool::next_alloc_size wraps around to 0 so it allocates a new block of 0 bytes instead of 4GB. next_alloc_size should be of type size_t to match the pointer size to avoid this.
However it turns out that the underlying issue is that all file_entry entries are allocated in the fuse server thread but put back on the free-list in the worker threads where they cannot be reused by the fuse server thread. The result is that the fuse server thread keeps allocating new entries and the worker threads free-list keeps growing.
This PR fixes both.
This fixes #532