Fix anchor_plan persistence race that disconnects the app - #237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Planner moves a decision with
anchor_plan, its document write and sidecar write can overlap using the same storage revision. The resulting conflict shuts down the server and disconnects the local app.Await the document publication before persisting sidecar state and broadcasting anchors. Extend the existing decision-placement test to hold publication pending and verify that persistence waits. Remove the resolved ordering gap from the architecture notes and agent instructions.
Validation:
bun test(1,792 passed, 2 PostgreSQL tests skipped),bun run types, andbun run cipassed. Existing lint warnings remain.Write ordering