Skip to content

[fix][dingo] Ensure consistency in the usage of chat_template_kwargs … #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
githubgxll merged 1 commit into from
Aug 17, 2026
+4 −1
Merged

[fix][dingo] Ensure consistency in the usage of chat_template_kwargs … #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dingo/frontend/prepost.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ def _prepare_request(
)
else None
)
chat_template_kwargs = dict(request_for_sampling.chat_template_kwargs or {})
raw_ctk = (
request.get("chat_template_args") if isinstance(request, dict) else None
)
chat_template_kwargs = dict(request_for_sampling.chat_template_kwargs or raw_ctk or {})
chat_template_kwargs["reasoning_effort"] = request_for_sampling.reasoning_effort

# Mistral warns that tokenize=False is unsafe for chat templates.
Expand Down
Loading