Repository navigation
fix(extensions): preserve skills mode on update - #5120
Open
mikamikasuki wants to merge 1 commit into
Open
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
Keep command registration disabled when updating extensions in AI-skills mode, allowing the update path to continue registering the rendered skill artifact. Assisted-by: OpenAI Codex (model: GPT-6 Luna high, autonomous)
mnriem
added
the
triage-must-have
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved skill-registration regressions and incompatible update test doubles block approval.
5 open issues
What changed in this PR
This PR aims to preserve skills-mode extension registration during updates, addressing #5105 by passing the saved project mode through archive installation.
Changes:
- Adds command-registration control to archive and ZIP installers.
- Applies the saved skills-mode setting during extension updates.
- Adds a Claude skills-mode regression test and updates an installer test double.
Verification used source inspection and an isolated signature check; project tests were not run.
AI-generated review: GitHub Copilot, model unknown, automated, for the requester.
| File | Description |
|---|---|
| tests/specify_cli/extensions/test_command_update.py | Adds skills-mode update coverage and forwards the registration flag in a test double. |
| src/specify_cli/extensions/_command_update_transaction.py | Selects registration behavior from saved skills-mode options. |
| src/specify_cli/extensions/__init__.py | Forwards registration control through archive and ZIP installation. |
Review effort: Max
Comment on lines
+557
to
+559
| register_commands=not is_ai_skills_enabled( | ||
| _commands.load_init_options(project_root) | ||
| ), |
Comment on lines
+557
to
+559
| register_commands=not is_ai_skills_enabled( | ||
| _commands.load_init_options(project_root) | ||
| ), |
Comment on lines
+557
to
+559
| register_commands=not is_ai_skills_enabled( | ||
| _commands.load_init_options(project_root) | ||
| ), |
Comment on lines
554
to
561
| _ = manager.install_from_zip( | ||
| archive_path, | ||
| speckit_version, | ||
| register_commands=not is_ai_skills_enabled( | ||
| _commands.load_init_options(project_root) | ||
| ), | ||
| catalog_name=update.catalog_name, | ||
| ) |
|
|
||
| manager = ExtensionManager(project_dir) | ||
| v1_dir = self._create_extension_source(tmp_path, "1.0.0") | ||
| manager.install_from_directory(v1_dir, "0.1.0", register_commands=False) |
Collaborator
|
Please address Copilot feedback. If not applicable, please explain why |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5105
Description
Updating an extension while Claude skills mode is enabled must preserve its skill registration without registering command files. This change passes the current skills-mode setting through the update installation paths, so updates keep the skills integration active and do not reintroduce commands.
Testing
AI Disclosure
OpenAI Codex (GPT-6 Luna high, autonomous mode) assisted with implementation and regression-test generation. The contributor reviewed and understands the submitted changes.