fix: preserve extension authors in generated skills - #4459
Open
philo-x wants to merge 3 commits into
Open
Conversation
Carry extension author metadata through skill registration, aliases, and restoration after preset removal. Keep the existing default for core skills and extensions without an author. Assisted-by: OpenAI Codex (model: GPT-6, autonomous)
Assisted-by: OpenAI Codex (model: GPT-6, autonomous)
Assisted-by: OpenAI Codex (model: GPT-6, autonomous)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An extension declaring
author: acme-corpcurrently produces skills attributed togithub-spec-kit. Pass the declared author through command registration and skill rendering, including aliases, dev-mode output, and restoration of extension skills after preset removal. Core generation and extensions with a missing or empty author retain the existinggithub-spec-kitdefault.Closes #4458.
Testing
4a7341a9), the 8 explicit-author cases fail; all pass with this change..venv/bin/python -m pytest tests/test_extensions.py tests/test_extension_skills.py tests/test_presets.py tests/integrations -q -k 'not test_ps_variant_prefixed_with_powershell_launcher'— 4202 passed, 5 skipped, 1 deselected.pwshnorpowershellis installed locally. Reproduced the same failure against unmodified main in an isolated checkout.uvx ruff@0.15.0 check src testsandgit diff --check: passed..venv/bin/specify --helpand a fresh CLIinitfollowed byextension add --dev: the extension skill attributesacme-corp, while the core plan skill retainsgithub-spec-kit.AI Disclosure
Implementation, regression tests, validation, commits, and this PR description were authored by OpenAI Codex (model: GPT-6, autonomous) on behalf of @philo-x. Each commit includes an
Assisted-by:trailer.