fix(github-http): validate release asset metadata URLs - #4438
Open
WOLIKIMCHENG wants to merge 1 commit into
Open
fix(github-http): validate release asset metadata URLs#4438WOLIKIMCHENG wants to merge 1 commit into
WOLIKIMCHENG wants to merge 1 commit into
Conversation
Require metadata asset URLs to match the derived API origin, repository identity, and exact numeric release-asset endpoint. Reject malformed metadata URLs while preserving direct passthrough and browser-download fallback behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Harden GitHub release-asset resolution so release metadata can replace a browser download URL only when the metadata URL:
This preserves public GitHub and GHES behavior, including custom ports, equivalent IPv6 literals, loopback HTTP, direct API-asset passthrough, and fallback to the original browser download URL.
Testing
uvx ruff@0.15.0 check src tests— all checks passed.venv/bin/python -m pytest tests/test_github_http.py -q— 78 passedgit diff --check— passed