-
Notifications
You must be signed in to change notification settings - Fork 7.4k
fix: unofficial PyPI warning (#1982) and legacy extension command name auto-correction (#2017) #2027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mbachorik
wants to merge
10
commits into
github:main
Choose a base branch
from
mbachorik:fix/pypi-warning-and-legacy-extension-names
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: unofficial PyPI warning (#1982) and legacy extension command name auto-correction (#2017) #2027
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
879ddd4
docs: warn about unofficial PyPI packages and recommend version verif…
b2c4f99
fix(extensions): auto-correct legacy command names instead of hard-fa…
44d1996
fix(tests): isolate preset catalog search test from community catalog…
fc99452
fix(extensions): extend auto-correction to aliases (#2017)
16f03ff
fix(extensions): address PR review feedback (#2017)
d643d0f
Update docs/installation.md
mbachorik 61984d4
fix(extensions): warn when hook command refs are silently canonicaliz…
ee106d1
fix(extensions): raise ValidationError for non-dict hook entries
bc3edb1
fix(extensions): derive remove cmd_count from registry, fix wording
b7d22da
fix(extensions): distinguish missing vs empty registered_commands in …
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd_countis computed usingmax(len(v) ...)across agents, but the removal prompt says "across AI agents". Ifregistered_commandsdiffers per agent (possible if registration partially succeeded or agent dirs changed),maxcan undercount the total files that will be removed. Consider either summing across agents for an "across agents" total, or clarifying the wording as "up to N commands per agent" ifmaxis intentional to avoid double-counting.