feat(canvas): persist improvement actions and synchronization

.github/extensions/replica-prototype/README.md

@@ -68,6 +68,10 @@ Plugin/Hub compatibility uses the supported Canvas interface, not matching relea
 
 Contributors can load uncommitted changes from a local Replica checkout with `copilot --plugin-dir` instead of editing an installed copy. See the [contributor workflow](../../../hub/docs/prototype-canvas.md#contributor-workflow) for local setup and asset build commands.
 
+## Improvement-note persistence
+
+New improvements remain local until their captured source matches a successful published Build, including on branches with an older Build. Clients capture the source without changing the real Git index. Capture failures or missing provenance still allow local use but prevent synchronization. Once uploaded, later changes retain the original Build identity and remain tied to their creator. See the [persistence guide](../../../hub/docs/prototype-canvas.md#improvement-note-persistence) for the runtime API.
+
 ## Learnings
 
 When this repository has a Hub connection and a Hub administrator connected Copilot, each prompt you submit gets the [learnings](../../../hub/docs/learnings.md) your repository's administrators accepted in Hub. The extension never sends your prompt to Hub. Copilot treats the learnings as guidance from your team, not as commands. Its first successful answer replaces earlier learning context, including after a restart or session resume; an empty answer explicitly clears it. Later unchanged answers add nothing. When learnings change, or Learnings is turned off, the next successful answer replaces the earlier guidance. It adds nothing when Hub's answer is not in the form that `replica-learning` writes. It never delays a prompt by more than three seconds and never fails it. Without a Hub connection it adds nothing and never asks you to connect. If you connected before the approval page mentioned learnings, disconnect and connect again to get them.

.github/extensions/replica-prototype/capture-review-revision/index.mjs

@@ -1,11 +1,17 @@
 import { mkdtemp, rm } from "node:fs/promises"
-import os from "node:os"
 import path from "node:path"
 
 import { runCommand } from "../run-command/index.mjs"
+import { gitShaPattern } from "../identity-patterns/index.mjs"
 
 export async function captureReviewRevision(context) {
-  const directory = await mkdtemp(path.join(os.tmpdir(), "replica-review-"))
+  const gitDirectory = await runCommand(
+    "git",
+    ["rev-parse", "--absolute-git-dir"],
+    context.repositoryPath,
+  )
+  if (!gitDirectory.ok) throw new Error("Could not locate the local review Git directory.")
+  const directory = await mkdtemp(path.join(gitDirectory.stdout.trim(), "replica-review-"))
   const env = { ...process.env, GIT_INDEX_FILE: path.join(directory, "index") }
   const config = ["-c", "core.fsmonitor=false", "-c", "core.hooksPath=/dev/null"]
   async function git(args, optional = false) {
@@ -26,7 +32,7 @@ export async function captureReviewRevision(context) {
     const head = (await git(["rev-parse", "HEAD"])).stdout.trim()
     const branch = (await git(["branch", "--show-current"])).stdout.trim()
     const headTree = (await git(["rev-parse", "HEAD^{tree}"])).stdout.trim()
-    if (!/^[0-9a-f]{40}$/.test(head) || !branch)
+    if (!gitShaPattern.test(head) || !branch)
       throw new Error("Open a committed, named branch before commenting.")
     await git(["read-tree", head])
     const files = (
@@ -83,7 +89,7 @@ export async function captureReviewRevision(context) {
     const untracked = (await git(["ls-files", "--others", "--exclude-standard"])).stdout
     if (currentHead !== head || currentBranch !== branch || !remaining.ok || untracked)
       throw new Error("The checkout changed while capturing this review revision. Try again.")
-    if (!/^[0-9a-f]{40}$/.test(treeSha))
+    if (!gitShaPattern.test(treeSha))
       throw new Error("Could not verify the local review source tree.")
     return { treeSha, commitSha: head, clean: treeSha === headTree }
   } finally {

.github/extensions/replica-prototype/create-canvas-context/index.mjs

@@ -9,6 +9,7 @@ export async function createCanvasContext({
   branch,
   commitSha,
   publishedUrl,
+  improvementThreadsSample = false,
   sessionId,
   sessionWorkspacePath,
   repositoryPath,
@@ -24,6 +25,8 @@ export async function createCanvasContext({
     )
   }
   const normalizedUrl = normalizePrototypeUrl(prototypeUrl)
+  if (typeof improvementThreadsSample !== "boolean")
+    throw new Error("improvementThreadsSample must be a boolean.")
   const stateUrl = new URL(normalizedUrl)
   stateUrl.hash = ""
   const resolvedRepositoryPath = path.resolve(repositoryPath)
@@ -58,6 +61,7 @@ export async function createCanvasContext({
     stateFile: path.join(stateDirectory, `${stateId}.json`),
     stateId,
     urlHost: new URL(normalizedUrl).host,
+    ...(improvementThreadsSample ? { improvementThreadsSample: true } : {}),
   }
 }
 // Keep stored publish state tied to the branch currently shown in the canvas.
@@ -82,6 +86,7 @@ export async function currentCanvasContext(context) {
     repository: currentRepository,
     branch: currentBranch,
     publishedUrl: context.target.publishedUrl,
+    improvementThreadsSample: context.improvementThreadsSample,
     sessionId: context.sessionId,
     sessionWorkspacePath: context.sessionWorkspacePath,
     repositoryPath: context.repositoryPath,

.github/extensions/replica-prototype/create-canvas-context/index.mts

@@ -11,6 +11,7 @@ type CanvasContextInput = {
   branch?: unknown
   commitSha?: unknown
   publishedUrl?: string | null
+  improvementThreadsSample?: boolean
   sessionId?: string
   sessionWorkspacePath?: string
   repositoryPath?: string
@@ -30,6 +31,7 @@ export async function createCanvasContext({
   branch,
   commitSha,
   publishedUrl,
+  improvementThreadsSample = false,
   sessionId,
   sessionWorkspacePath,
   repositoryPath,
@@ -46,6 +48,8 @@ export async function createCanvasContext({
   }
 
   const normalizedUrl = normalizePrototypeUrl(prototypeUrl)
+  if (typeof improvementThreadsSample !== "boolean")
+    throw new Error("improvementThreadsSample must be a boolean.")
   const stateUrl = new URL(normalizedUrl)
   stateUrl.hash = ""
   const resolvedRepositoryPath = path.resolve(repositoryPath)
@@ -81,6 +85,7 @@ export async function createCanvasContext({
     stateFile: path.join(stateDirectory, `${stateId}.json`),
     stateId,
     urlHost: new URL(normalizedUrl).host,
+    ...(improvementThreadsSample ? { improvementThreadsSample: true } : {}),
   }
 }
 
@@ -107,6 +112,7 @@ export async function currentCanvasContext(context: CanvasContext): Promise<Canv
     repository: currentRepository,
     branch: currentBranch,
     publishedUrl: context.target.publishedUrl,
+    improvementThreadsSample: context.improvementThreadsSample,
     sessionId: context.sessionId,
     sessionWorkspacePath: context.sessionWorkspacePath,
     repositoryPath: context.repositoryPath,

.github/extensions/replica-prototype/create-canvas-context/index.test.mjs

@@ -18,6 +18,23 @@ const base = {
 }
 
 describe("createCanvasContext()", () => {
+  it("keeps thread samples explicitly opted in without changing saved-note identity", async () => {
+    await withContext(async (fixture) => {
+      const input = { ...base, ...paths(fixture) }
+      const ordinary = await createCanvasContext(input)
+      const sample = await createCanvasContext({ ...input, improvementThreadsSample: true })
+      assert.equal(ordinary.improvementThreadsSample, undefined)
+      assert.equal(sample.improvementThreadsSample, true)
+      assert.equal(sample.stateId, ordinary.stateId)
+      execFileSync("git", ["checkout", "-qb", "thread-sample"], { cwd: fixture.repositoryPath })
+      assert.equal((await currentCanvasContext(sample)).improvementThreadsSample, true)
+      await assert.rejects(
+        createCanvasContext({ ...input, improvementThreadsSample: "true" }),
+        /must be a boolean/,
+      )
+    })
+  })
+
   it("normalizes the URL and retains explicit target metadata", async () => {
     await withContext(async (fixture) => {
       const input = { ...base, ...paths(fixture) }
@@ -49,8 +66,13 @@ describe("createCanvasContext()", () => {
     await withContext(async (fixture) => {
       const input = { ...base, ...paths(fixture) }
       const original = await createCanvasContext(input)
-      execFileSync("git", ["checkout", "-qb", "another"], { cwd: fixture.repositoryPath })
-      const changed = await createCanvasContext({ ...input, branch: "another" })
+      execFileSync("git", ["checkout", "-qb", "another"], {
+        cwd: fixture.repositoryPath,
+      })
+      const changed = await createCanvasContext({
+        ...input,
+        branch: "another",
+      })
       assert.notEqual(original.stateId, changed.stateId)
     })
   })
@@ -79,7 +101,10 @@ describe("createCanvasContext()", () => {
         cwd: fixture.repositoryPath,
       })
       const input = { ...base, ...paths(fixture) }
-      const supplied = await createCanvasContext({ ...input, repository: "GitHub/Replica" })
+      const supplied = await createCanvasContext({
+        ...input,
+        repository: "GitHub/Replica",
+      })
       assert.equal(supplied.target.repository, "github/replica")
       const discovered = await createCanvasContext({
         ...input,
@@ -157,7 +182,9 @@ describe("createCanvasContext()", () => {
     const repositoryPath = path.join(workspace, ".local/prototypes/example")
     await mkdir(repositoryPath, { recursive: true })
     try {
-      execFileSync("git", ["init", "-q", "-b", "main"], { cwd: repositoryPath })
+      execFileSync("git", ["init", "-q", "-b", "main"], {
+        cwd: repositoryPath,
+      })
       execFileSync("git", ["remote", "add", "origin", "https://github.com/github/replica.git"], {
         cwd: repositoryPath,
       })
@@ -196,7 +223,10 @@ describe("createCanvasContext()", () => {
         createCanvasContext(input),
         /Cannot verify repository hint: The origin remote is not a GitHub repository/,
       )
-      const withoutHint = await createCanvasContext({ ...input, repository: undefined })
+      const withoutHint = await createCanvasContext({
+        ...input,
+        repository: undefined,
+      })
       assert.equal(withoutHint.target.repository, null)
       execFileSync(
         "git",

.github/extensions/replica-prototype/create-hub-client/authorization.test.mjs

@@ -11,7 +11,9 @@ import { createHubClient } from "./index.mjs"
 it("verifies repository authorization independently of branch discovery and never trusts a bare 404", async (t) => {
   const root = await mkdtemp(path.join(os.tmpdir(), "replica-authorization-"))
   t.after(() => rm(root, { recursive: true, force: true }))
-  execFileSync("git", ["init", "-b", "prototype/new", root], { stdio: "ignore" })
+  execFileSync("git", ["init", "-b", "prototype/new", root], {
+    stdio: "ignore",
+  })
   execFileSync("git", [
     "-C",
     root,
@@ -23,6 +25,7 @@ it("verifies repository authorization independently of branch discovery and neve
   let status = 200
   let repository = "github/prototype"
   let canPublish = false
+  let viewer = { viewerId: 7, viewerLogin: "mona" }
   const server = createServer((request, response) => {
     response.setHeader("X-Replica-Canvas-Version", "1")
     if (request.url.startsWith("/api/canvas/prototype")) {
@@ -32,7 +35,7 @@ it("verifies repository authorization independently of branch discovery and neve
       assert.equal(request.url, "/api/canvas/connection")
       assert.equal(request.headers.authorization, "Bearer fixture-token")
       response.writeHead(status, { "Content-Type": "application/json" })
-      response.end(JSON.stringify({ repository, canPublish }))
+      response.end(JSON.stringify({ repository, canPublish, ...viewer }))
     }
   })
   await new Promise((resolve) => server.listen(0, "127.0.0.1", resolve))
@@ -57,6 +60,28 @@ it("verifies repository authorization independently of branch discovery and neve
   assert.equal(authorized.repositoryAuthorized, true)
   assert.equal(authorized.branch, "prototype/new")
   assert.equal(authorized.canPublish, false)
+  assert.equal(authorized.viewerId, 7)
+  assert.equal(authorized.viewerLogin, "mona")
+  const expectedTarget = { repository, branch: "prototype/new" }
+  const scope = {}
+  const readOnly = await client.status({
+    register: false,
+    expectedTarget,
+    connectionScope: scope,
+  })
+  assert.equal(readOnly.viewerId, 7)
+  assert.ok(scope.identity)
+  viewer = { viewerLogin: "mona" }
+  assert.equal((await client.status({ register: false })).viewerId, undefined)
+  for (const invalid of [
+    { viewerId: "7", viewerLogin: "mona" },
+    { viewerId: 0, viewerLogin: "mona" },
+    { viewerId: 7, viewerLogin: "../user" },
+  ]) {
+    viewer = invalid
+    assert.equal((await client.status({ register: false })).state, "unavailable")
+  }
+  viewer = { viewerId: 7, viewerLogin: "mona" }
   canPublish = true
   assert.equal((await client.status()).canPublish, true)
   for (const code of [401, 403, 404, 500]) {

.github/extensions/replica-prototype/create-hub-client/index.mjs

@@ -6,6 +6,7 @@ import { readCanvasRepository } from "../read-canvas-repository/index.mjs"
 import { runCommand } from "../run-command/index.mjs"
 import { createPrivateStore } from "../private-store/index.mjs"
 import { normalizeHubOrigin } from "../normalize-hub-origin/index.mjs"
+import { githubLoginPattern } from "../identity-patterns/index.mjs"
 
 function registrationReason(value) {
   if (value == null) return undefined
@@ -14,6 +15,18 @@ function registrationReason(value) {
   return value
 }
 
+function connectionViewer(connection) {
+  if (connection.viewerId == null) return {}
+  if (
+    !Number.isSafeInteger(connection.viewerId) ||
+    connection.viewerId < 1 ||
+    typeof connection.viewerLogin !== "string" ||
+    !githubLoginPattern.test(connection.viewerLogin)
+  )
+    throw new Error("Hub returned an invalid connected author.")
+  return { viewerId: connection.viewerId, viewerLogin: connection.viewerLogin }
+}
+
 export function createHubClient(context, options = {}) {
   const origin = new URL(normalizeHubOrigin(options.origin || process.env.REPLICA_HUB_ORIGIN))
   const directory = options.directory || path.join(os.homedir(), ".config", "replica", "canvas")
@@ -269,7 +282,7 @@ export function createHubClient(context, options = {}) {
       const credential = await credentialFor(repository)
       return credential ? connectionIdentity(credential) : null
     },
-    async status() {
+    async status({ register = true, expectedTarget, connectionScope } = {}) {
       const target = await checkout()
       if (!target.repository) {
         return {
@@ -278,12 +291,20 @@ export function createHubClient(context, options = {}) {
         }
       }
       try {
-        const credential = await credentialFor(target.repository)
+        const credential = await credentialFor(target.repository, undefined, connectionScope)
+        const lookup = (route) =>
+          register
+            ? authorizedRequest(target.repository, credential, route)
+            : this.request(route, {
+                expectedTarget: expectedTarget ?? target,
+                connectionScope,
+              })
         if (!credential) {
           const pending = await readPending(target.repository)
           if (pending?.refreshToken && Date.parse(pending.expiresAt) <= Date.now()) {
             const result = await this.poll()
-            if (result.status === "approved") return this.status()
+            if (result.status === "approved")
+              return this.status({ register, expectedTarget, connectionScope })
           }
           const pairing = pending && Date.parse(pending.expiresAt) > Date.now()
           const previous = await readCredential(target.repository)
@@ -300,11 +321,7 @@ export function createHubClient(context, options = {}) {
           }
         }
         if (!target.branch) {
-          const connection = await authorizedRequest(
-            target.repository,
-            credential,
-            "/api/canvas/connection",
-          )
+          const connection = await lookup("/api/canvas/connection")
           if (connection.repository?.toLowerCase() !== target.repository.toLowerCase())
             throw new Error("Hub did not verify this repository.")
           return {
@@ -313,25 +330,20 @@ export function createHubClient(context, options = {}) {
             reviewConnectionId: connectionIdentity(credential),
             canPublish: connection.canPublish,
             viewerLogin: connection.viewerLogin,
+            ...connectionViewer(connection),
             repository: target.repository,
             commitSha: target.commitSha,
             message: "Connected to this repository. Open a named branch for Builds and reviews.",
           }
         }
         let prototype
         try {
-          prototype = await authorizedRequest(
-            target.repository,
-            credential,
+          prototype = await lookup(
             `/api/canvas/prototype?branch=${encodeURIComponent(target.branch)}`,
           )
         } catch (error) {
           if (error.statusCode !== 404) throw error
-          const connection = await authorizedRequest(
-            target.repository,
-            credential,
-            "/api/canvas/connection",
-          )
+          const connection = await lookup("/api/canvas/connection")
           if (connection.repository?.toLowerCase() !== target.repository.toLowerCase())
             throw new Error("Hub did not verify this repository.", {
               cause: error,
@@ -342,6 +354,7 @@ export function createHubClient(context, options = {}) {
             reviewConnectionId: connectionIdentity(credential),
             canPublish: connection.canPublish,
             viewerLogin: connection.viewerLogin,
+            ...connectionViewer(connection),
             repository: target.repository,
             branch: target.branch,
             commitSha: target.commitSha,
@@ -351,6 +364,7 @@ export function createHubClient(context, options = {}) {
         let registrationError
         let reason = registrationReason(prototype.registrationReason)
         if (
+          register &&
           !prototype.registered &&
           prototype.canEdit &&
           prototype.canRegister &&