Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions pkg/github/copilot.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,19 @@ func AssignCopilotToIssue(t translations.TranslationHelperFunc) inventory.Server
return utils.NewToolResultError(err.Error()), nil, nil
}

// owner, repo and issue_number are required, but WeakDecode zero-fills a
// missing value, so a missing arg reached the query as a confusing
// "Could not resolve to a Repository" error. Reject the zero values.
if params.Owner == "" {
return utils.NewToolResultError("missing required parameter: owner"), nil, nil
}
if params.Repo == "" {
return utils.NewToolResultError("missing required parameter: repo"), nil, nil
}
if params.IssueNumber == 0 {
return utils.NewToolResultError("missing required parameter: issue_number"), nil, nil
}

client, err := deps.GetGQLClient(ctx)
if err != nil {
return nil, nil, fmt.Errorf("failed to get GitHub client: %w", err)
Expand Down Expand Up @@ -588,6 +601,19 @@ func AssignCopilotToIssueWithIntent(t translations.TranslationHelperFunc) invent
return utils.NewToolResultError(err.Error()), nil, nil
}

// owner, repo and issue_number are required, but WeakDecode zero-fills a
// missing value, so reject the zero values (as with rationale/confidence
// below) before they reach the query as a confusing repository error.
if params.Owner == "" {
return utils.NewToolResultError("missing required parameter: owner"), nil, nil
}
if params.Repo == "" {
return utils.NewToolResultError("missing required parameter: repo"), nil, nil
}
if params.IssueNumber == 0 {
return utils.NewToolResultError("missing required parameter: issue_number"), nil, nil
}

// Validate rationale length (rune count, matching the granular assignee tools).
rationale := strings.TrimSpace(params.Rationale)
if rationale == "" {
Expand Down
43 changes: 43 additions & 0 deletions pkg/github/copilot_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,36 @@ func TestAssignCopilotToIssue(t *testing.T) {
expectToolError bool
expectedToolErrMsg string
}{
{
name: "missing owner is rejected",
requestArgs: map[string]any{
"repo": "repo",
"issue_number": float64(123),
},
mockedClient: githubv4mock.NewMockedHTTPClient(),
expectToolError: true,
expectedToolErrMsg: "missing required parameter: owner",
},
{
name: "missing repo is rejected",
requestArgs: map[string]any{
"owner": "owner",
"issue_number": float64(123),
},
mockedClient: githubv4mock.NewMockedHTTPClient(),
expectToolError: true,
expectedToolErrMsg: "missing required parameter: repo",
},
{
name: "missing issue_number is rejected",
requestArgs: map[string]any{
"owner": "owner",
"repo": "repo",
},
mockedClient: githubv4mock.NewMockedHTTPClient(),
expectToolError: true,
expectedToolErrMsg: "missing required parameter: issue_number",
},
{
name: "successful assignment when there are no existing assignees",
requestArgs: map[string]any{
Expand Down Expand Up @@ -1228,6 +1258,19 @@ func TestAssignCopilotToIssueWithIntent(t *testing.T) {
expectedToolErrMsg string
expectSuggestion bool
}{
{
name: "missing owner is rejected",
requestArgs: map[string]any{
"repo": "repo",
"issue_number": float64(123),
"rationale": "Well-scoped task.",
"confidence": "HIGH",
"is_suggestion": false,
},
mockedClient: githubv4mock.NewMockedHTTPClient(),
expectToolError: true,
expectedToolErrMsg: "missing required parameter: owner",
},
{
name: "direct assignment with rationale and confidence preserves existing assignees",
requestArgs: map[string]any{
Expand Down