Accept `status_changed` issue triggers by Copilot · Pull Request #77179 · github/gh-aw

Copilot · 2026-11-12T15:03:21Z

on.issues.types rejected GitHub’s preview status_changed activity. Add support while keeping invalid values such as status_change rejected.

Schemas: Update the frontmatter schema and generated Actions schema; fix the Makefile selector to patch issue types nested under oneOf.
Compiler validation: Extend the compiler overlay with status_changed while preserving the pinned upstream schema.

on:
  issues:
    types: [status_changed]

Fixes Accept status_changed in on.issues.types #77162

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

github-actions · 2026-11-12T17:31:04Z

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · routed: gpt61 medium · ~5 AIC · ⌖ ~1 AIC · ◇ ~1 AIC · ⊞ 181 · ◷

Generated by Ponytail Reviewer for #77179

github-actions · 2026-11-12T17:31:06Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-11-12T17:31:06Z

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · routed: sonnet55 high · ~6 AIC · ⌖ ~2 AIC · ◇ ~1 AIC · ⊞ 8.5K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-11-12T17:31:23Z

✅ PR Specification Reviewer completed successfully!

PR Specification Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from PR Specification Reviewer · gpt56 · ~2 AIC · ⌖ ~1 AIC · ◇ ~1 AIC · ⊞ 1.6K · ◷

Generated by PR Specification Reviewer for #77179

github-actions · 2026-11-12T17:31:42Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-11-12T17:31:53Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · routed: haiku55 xhigh · ~1 AIC · ⌖ ~2 AIC · ◇ ~1 AIC · ⊞ 7.2K · ◷

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-11-12T17:37:55Z

Comment Memory

Peek at saved memory (pr-code-quality-reviewer)

reviewed_at: 2026-11-12T17:35:00Z
review_event: COMMENT
top_themes: [schema regeneration robustness]
files_reviewed: [Makefile, pkg/parser/schema_test.go, pkg/parser/schemas/main_workflow_schema.json, pkg/workflow/actionslanguageservice/compiler_schema.go, pkg/workflow/actionslanguageservice/compiler_schema_test.go, pkg/workflow/schema_validation_test.go, pkg/workflow/schemas/github-workflow.json]
comment_count: 1

Note

This comment is managed by comment memory.

Expand the saved memory block to view or edit the persistent context for this thread.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~2 AIC · ⊞ 1.6K · ◷
_{Comment /review to run again}

github-actions

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~2 AIC · ⊞ 1.6K
_{Comment /review to run again}

github-actions · 2026-11-12T17:37:58Z

 	@echo "Patching GitHub Actions schema with custom permissions..."
 	@tmpfile=$$(mktemp) && \
-		jq 'def append_missing($$items): reduce $$items[] as $$item (. ; if index($$item) then . else . + [$$item] end); .definitions["permissions-event"].properties += {"copilot-requests": {"type": "string", "enum": ["write", "none"]}, "drives": {"$$ref": "#/definitions/permissions-level"}, "vulnerability-alerts": {"type": "string", "enum": ["read", "none"]}} | (.properties.on.oneOf[] | select(.properties? and .properties.issues? and .properties.issues.properties? and .properties.issues.properties.types?).properties.issues.properties.types.items.enum) |= append_missing(["typed", "untyped", "field_added", "field_removed"]) | (.properties.on.oneOf[] | select(.properties? and .properties.issues? and .properties.issues.properties? and .properties.issues.properties.types?).properties.issues.properties.types.default) |= append_missing(["typed", "untyped", "field_added", "field_removed"])' \
+		jq 'def append_missing($$items): reduce $$items[] as $$item (. ; if index($$item) then . else . + [$$item] end); .definitions["permissions-event"].properties += {"copilot-requests": {"type": "string", "enum": ["write", "none"]}, "drives": {"$$ref": "#/definitions/permissions-level"}, "vulnerability-alerts": {"type": "string", "enum": ["read", "none"]}} | (.properties.on.oneOf[] | select(.properties?.issues?.oneOf?) | .properties.issues.oneOf[] | select(.properties?.types?).properties.types.items.enum) |= append_missing(["typed", "untyped", "field_added", "field_removed", "status_changed"]) | (.properties.on.oneOf[] | select(.properties?.issues?.oneOf?) | .properties.issues.oneOf[] | select(.properties?.types?).properties.types.default) |= append_missing(["typed", "untyped", "field_added", "field_removed", "status_changed"])' \


The selector now depends on the downloaded schema representing issues as an object containing oneOf; if SchemaStore changes that shape, both |= paths silently match nothing and this target still succeeds, leaving the generated schema without status_changed. That turns a regeneration into a latent validation regression. Please make the target assert that the resulting enum/default contain status_changed (or otherwise fail when the selector matches no nodes).

Added a fail-fast selector check and verified that every matched issue enum and default contains status_changed, so schema regeneration cannot silently no-op.

github-actions

Found one maintainability/correctness risk in the schema regeneration target: the jq selector can silently no-op if the upstream schema shape changes, allowing a generated schema without status_changed to be committed. Please add an assertion or fail-fast check after patching. No tests were run per static-review instructions.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~2 AIC · ⌖ ~2 AIC · ⊞ 1.6K
_{Comment /review to run again}

Copilot

🟢 Approval recommended

No active review issues were identified for the change adding status_changed issue activity support.

No open issues 🎉

What changed in this PR

Adds support for the preview status_changed issue activity in gh-aw, addressing #77162 while continuing to reject invalid values such as status_change.

Changes:

Updates the frontmatter and generated Actions schemas to accept status_changed.
Fixes the Makefile selector for nested issue activity types.
Extends compiler validation without modifying the pinned upstream schema, with positive and negative regression tests.

File	Description
`pkg/workflow/schemas/github-workflow.json`	Adds `status_changed` to issue activity values and defaults.
`pkg/workflow/schema_validation_test.go`	Tests valid and misspelled issue activity types.
`pkg/workflow/actionslanguageservice/compiler_schema.go`	Extends the compiler overlay using a copied activity-type slice.
`pkg/workflow/actionslanguageservice/compiler_schema_test.go`	Tests acceptance, typo rejection, and upstream schema isolation.
`pkg/parser/schemas/main_workflow_schema.json`	Allows `status_changed` in workflow frontmatter.
`pkg/parser/schema_test.go`	Tests frontmatter acceptance and typo rejection.
`Makefile`	Corrects the nested schema selector and includes `status_changed`.

_{Review effort: Balanced (auto)}

github-actions

Skills-Based Review 🧠

Applied /codebase-design, /tdd, and a schema-consistency check. The change is correct. I found no blocking issues, only robustness and clarity suggestions.

📋 Verification performed

The jq selector matches exactly one upstream issues entry, and the Makefile recipe is idempotent on the committed schema.
All three schema copies (pkg/workflow/schemas, pkg/parser/schemas, and the overlay) are consistent.
The issues-activity-type overlay key exists in workflow-v1.0.json.
Targeted tests pass: actionslanguageservice, parser, and workflow schema tests.

💬 Open questions

The webhook gateway catalog (actions/setup/js/github_notification_webhooks.json) and its spec table (docs/src/content/docs/specs/webhook-gateway-specification.md) still omit status_changed. Confirm whether that is intentional scope. If the gateway should accept it, update both.
The jq selector fails open if the upstream shape changes (see the inline comment on the Makefile).

See the three inline comments for details. @copilot please address the review comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~3 AIC · ⌖ ~2 AIC · ⊞ 6.6K
_{Comment /matt to run again}

github-actions · 2026-11-12T17:41:19Z

 	@echo "Patching GitHub Actions schema with custom permissions..."
 	@tmpfile=$$(mktemp) && \
-		jq 'def append_missing($$items): reduce $$items[] as $$item (. ; if index($$item) then . else . + [$$item] end); .definitions["permissions-event"].properties += {"copilot-requests": {"type": "string", "enum": ["write", "none"]}, "drives": {"$$ref": "#/definitions/permissions-level"}, "vulnerability-alerts": {"type": "string", "enum": ["read", "none"]}} | (.properties.on.oneOf[] | select(.properties? and .properties.issues? and .properties.issues.properties? and .properties.issues.properties.types?).properties.issues.properties.types.items.enum) |= append_missing(["typed", "untyped", "field_added", "field_removed"]) | (.properties.on.oneOf[] | select(.properties? and .properties.issues? and .properties.issues.properties? and .properties.issues.properties.types?).properties.issues.properties.types.default) |= append_missing(["typed", "untyped", "field_added", "field_removed"])' \
+		jq 'def append_missing($$items): reduce $$items[] as $$item (. ; if index($$item) then . else . + [$$item] end); .definitions["permissions-event"].properties += {"copilot-requests": {"type": "string", "enum": ["write", "none"]}, "drives": {"$$ref": "#/definitions/permissions-level"}, "vulnerability-alerts": {"type": "string", "enum": ["read", "none"]}} | (.properties.on.oneOf[] | select(.properties?.issues?.oneOf?) | .properties.issues.oneOf[] | select(.properties?.types?).properties.types.items.enum) |= append_missing(["typed", "untyped", "field_added", "field_removed", "status_changed"]) | (.properties.on.oneOf[] | select(.properties?.issues?.oneOf?) | .properties.issues.oneOf[] | select(.properties?.types?).properties.types.default) |= append_missing(["typed", "untyped", "field_added", "field_removed", "status_changed"])' \


[/codebase-design] The new selector is correct for the current schema (it matches exactly one issues entry). But if upstream reshapes on.issues.oneOf, select yields nothing, jq exits 0, and the enum patch becomes a silent no-op.

💡 Suggested guard

Fail the recipe when the selector matches nothing, for example by adding a stage before the patch:

if ([.properties.on.oneOf[] | select(.properties?.issues?.oneOf?)] | length) == 0 then error("issues types selector matched nothing") else . end

A cheap alternative is a jq -e assertion on the output that status_changed is present in the patched enum.

@copilot please address this.

Added the suggested guard plus a post-patch assertion for both the enum and default arrays in the Makefile target.

github-actions · 2026-11-12T17:41:20Z

+	statusChanged := "on:\n  issues:\n    types: [status_changed]\njobs:\n  build:\n    runs-on: ubuntu-latest\n    steps: [{run: echo hi}]\n"
+	require.NoError(t, ValidateWorkflowWithCacheMode("issues.yml", statusChanged))
+
+	_, err := ParseWorkflow("upstream.yml", statusChanged)


[/tdd] This assertion intentionally pins the upstream schema to reject status_changed, which proves the overlay is needed. That intent is not obvious, and the test will start failing once the pinned schema adds the value.

💡 Suggested clarification

Add a one-line comment above the ParseWorkflow call, for example: // Pinned upstream still rejects status_changed; this fails when the overlay is no longer needed.

@copilot please address this.

Added a test comment clarifying that the pinned upstream schema must reject status_changed until it includes the value.

github-actions · 2026-11-12T17:41:20Z

 	schema := maps.Clone(upstream)
 	schema["cache-mode"] = definition{AllowedValues: []string{"read", "write", "write-only", "none"}}
+	issuesActivityType := schema["issues-activity-type"]
+	issuesActivityType.AllowedValues = append(append([]string(nil), issuesActivityType.AllowedValues...), "status_changed")


[/codebase-design] Copying AllowedValues before appending correctly avoids mutating the cached upstream slice. That aliasing risk is non-obvious, so a short comment would help future edits.

@copilot please address this.

Added a comment explaining that the slice is copied before append to preserve the cached upstream schema.

pelikhan · 2026-11-12T18:43:58Z

@copilot run pr-finisher skill

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-11-12T19:18:32Z

@copilot run pr-finisher skill

Ran the PR finisher pass. Review fixes are in commit f716b5f; local formatting, lint, focused and impacted tests, and workflow drift checks passed. CI needs a maintainer re-trigger after this push.

Found one maintainability/correctness risk in the schema regeneration target: the jq selector can silently no-op if the upstream schema shape changes, allowing a generated schema without `status_chang...

Added a fail-fast selector guard and output assertions to the Makefile schema patch target.

github-actions · 2026-11-13T03:36:56Z

🎉 This pull request is included in a new release.

Release: v1.2.3

Initial plan

d166cee

Copilot AI assigned Copilot and pelikhan Nov 12, 2026

Copilot started work on behalf of pelikhan November 12, 2026 15:03

View session

Copilot AI linked an issue Nov 12, 2026 that may be closed by this pull request

Accept status_changed in on.issues.types #77162

Closed

Accept status_changed issue activity type

ef05fd9

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add status_changed to on.issues.types~~ Accept status_changed issue triggers Nov 12, 2026

Copilot AI requested a review from pelikhan November 12, 2026 15:54

Copilot finished work on behalf of pelikhan November 12, 2026 15:54

pelikhan marked this pull request as ready for review November 12, 2026 17:29

Copilot AI dynamic review requested due to automatic review settings November 12, 2026 17:29

Copilot started reviewing on behalf of pelikhan November 12, 2026 17:37

View session

github-actions Bot reviewed Nov 12, 2026

View reviewed changes

Copilot AI reviewed Nov 12, 2026

View reviewed changes

github-actions Bot reviewed Nov 12, 2026

View reviewed changes

Copilot started work on behalf of pelikhan November 12, 2026 18:44

View session

Address status_changed review feedback

f716b5f

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan November 12, 2026 19:19

pelikhan merged commit 7766e83 into main Nov 12, 2026
121 checks passed

pelikhan deleted the copilot/accept-status-changed-in-on-issues-types branch November 12, 2026 20:13

This was referenced Nov 13, 2026

Smoke Test: MAI-Code-1.1-Flash - 43333769148 #77245

Closed

[compiler-threat-spec] Daily compiler threat spec audit (2026-11-13) #77313

Merged

github-actions Bot mentioned this pull request Nov 13, 2026

[docs] Update documentation for features from 2026-11-13 #77419

Merged

Conversation

Copilot AI commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ponytail Reviewer

Uh oh!

github-actions Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Design Decision Gate 🏗️

Uh oh!

github-actions Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Specification Reviewer

Uh oh!

github-actions Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Quality Sentinel

Uh oh!

github-actions Bot commented Nov 12, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Uh oh!

github-actions Bot Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 12, 2026

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Nov 12, 2026

Uh oh!

Copilot AI commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Nov 13, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Copilot AI commented Nov 12, 2026 •

edited

Loading

github-actions Bot commented Nov 12, 2026 •

edited

Loading

github-actions Bot commented Nov 12, 2026 •

edited

Loading

github-actions Bot commented Nov 12, 2026 •

edited

Loading

github-actions Bot commented Nov 12, 2026 •

edited

Loading

github-actions Bot commented Nov 12, 2026 •

edited

Loading

github-actions Bot commented Nov 12, 2026 •

edited

Loading

Copilot AI commented Nov 12, 2026 •

edited

Loading