Skip to content

[compiler-threat-spec] docs: extend CTR-004 mapping for enclave GitHub proxy trust surface - #56521

Merged
pelikhan merged 1 commit into
mainfrom
spec/enclave-ctr004-mapping-audit-2026-08-28-841bdfcf79079378
Aug 28, 2026
Merged

[compiler-threat-spec] docs: extend CTR-004 mapping for enclave GitHub proxy trust surface#56521
pelikhan merged 1 commit into
mainfrom
spec/enclave-ctr004-mapping-audit-2026-08-28-841bdfcf79079378

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR is a documentation-only update to specs/compiler-threat-detection-spec.md, bumping the spec version from 1.0.27 to 1.0.28. It extends the CTR-004 Sandbox Bypass Configuration mapping table to document the enclave GitHub proxy trust surface (pkg/workflow/enclaves.go, pkg/workflow/enclave_github_proxy.go), which was already implemented and tested but had not previously been reflected in the Section 7.1 mapping table. No compiler behavior changes.

Change Classification

  • Type: docs
  • Scope: specs/compiler-threat-detection-spec.md
  • Breaking: No

Key Changes

File Change Impact
specs/compiler-threat-detection-spec.md Bumped spec version 1.0.27 → 1.0.28; added spec-to-implementation sync table entry (min gh-aw v0.87.4); extended CTR-004 mapping row with enclaves.go/enclave_github_proxy.go and their tests; added 1.0.28 changelog entry medium

Impact Assessment

  • No compiler code, schema, or .lock.yml changes — purely a mapping/documentation update.
  • Formally documents existing security controls for the enclaves[].agent.github.cli: issues-read-v1 proxy: AWF network-isolation precondition, AWF/MCPG minimum version gating, a fixed read-only operation allowlist (issues.comments.list, issues.get, issues.list), exclusion of GITHUB_TOKEN from the credential fallback chain, and repository count/sensitivity limits.
  • No new CTR-* threat rule introduced; existing CTR-004/CTR-017 coverage is confirmed sufficient.
  • No downstream impact on compiled workflows or lock-file compatibility.

Commits

9fa233249 docs: extend CTR-004 mapping for enclave GitHub proxy trust surface

Generated by PR Description Updater for #56521 · copilot · auto · 27 AIC · ⌖ 4.62 AIC · ⊞ 7.7K ·

Daily compiler threat spec optimizer review. Documents the already-
implemented enclave GitHub proxy network-isolation precondition,
version gating, read-only operation allowlist, and credential scoping
(pkg/workflow/enclaves.go, pkg/workflow/enclave_github_proxy.go) under
the existing CTR-004 Sandbox Bypass Configuration rule. No new threat
class identified; mapping-only update to Section 2 and Section 7.1.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot This PR has been quiet since creation. Please refresh the branch if needed, verify checks, and run the pr-finisher skill so the change is ready for maintainer review.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 33.6 AIC · ⌖ 9.8 AIC · ⊞ 6.4K ·
Comment /souschef to run again

Copilot AI commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@copilot This PR has been quiet since creation. Please refresh the branch if needed, verify checks, and run the pr-finisher skill so the change is ready for maintainer review.

Generated by [👨�...

Ran the pr-finisher pass:

  • Reviews: no open review threads/comments requiring action; this comment is acknowledged here.
  • Mergeable: branch is up to date with main (base sha matches), no conflicts, docs-only diff (1 file).
  • Checks: three workflow runs (AI Moderator, Content Moderation, Agentic Commands) are stuck at action_required because the PR was opened by github-actions[bot] and require a maintainer approval to run — this isn't something I can trigger from this sandbox (no gh/workflow-dispatch access, and I'm instructed never to trigger workflow runs). No code changes were needed since the content in the last commit is accurate (function names verified against pkg/workflow/enclaves.go / enclave_github_proxy.go).

Nothing else is actionable from the agent side — this PR needs a maintainer to approve the pending workflow runs before it can be merged.

Copilot AI requested a review from gh-aw-bot August 28, 2026 09:48
@pelikhan
pelikhan merged commit 23f4754 into main Aug 28, 2026
1 check passed
@pelikhan
pelikhan deleted the spec/enclave-ctr004-mapping-audit-2026-08-28-841bdfcf79079378 branch August 28, 2026 10:39
@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v0.87.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants