Skip to content

Split safe-output handler registry by category - #55501

Merged
pelikhan merged 3 commits into
mainfrom
copilot/deep-report-split-safe-outputs-handler
Aug 24, 2026
Merged

Split safe-output handler registry by category#55501
pelikhan merged 3 commits into
mainfrom
copilot/deep-report-split-safe-outputs-handler

Conversation

Copilot AI commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

The 1,091-line safe-output handler registry combined 50 inline handlers in one map, making reviews and concurrent changes unnecessarily difficult.

  • Registry organization

    • Split handlers into focused issue/discussion, pull request, automation, dispatch/reporting, and artifact/project registries.
    • Moved shared token resolution into a dedicated file.
    • Reduced the original registry file to category assembly.
  • Regression coverage

    • Verify all 50 handler keys are assembled exactly once.
    • Detect missing, duplicated, or unexpected registrations.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 10.3 AIC · ⌖ 9.22 AIC · ⊞ 6.2K ·
Comment /souschef to run again

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Split pkg/workflow/safe_outputs_handler_registry.go by handler category Split safe-output handler registry by category Aug 24, 2026
Copilot AI requested a review from pelikhan August 24, 2026 20:44
@pelikhan
pelikhan marked this pull request as ready for review August 24, 2026 22:02
Copilot AI balanced review requested due to automatic review settings August 24, 2026 22:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Splits the monolithic safe-output registry into focused category registries without changing handler behavior.

Changes:

  • Organizes all 50 handlers across five category files.
  • Extracts shared token-resolution helpers.
  • Adds coverage for missing, duplicate, and unexpected registrations.
Show a summary per file
File Description
pkg/workflow/safe_outputs_handler_registry.go Assembles category registries.
pkg/workflow/safe_outputs_handler_tokens.go Contains shared token helpers.
pkg/workflow/safe_outputs_handler_registry_test.go Verifies complete, unique registration.
pkg/workflow/safe_outputs_handler_registry_issues.go Registers issue and discussion handlers.
pkg/workflow/safe_outputs_handler_registry_pull_requests.go Registers pull-request handlers.
pkg/workflow/safe_outputs_handler_registry_automation.go Registers repository automation handlers.
pkg/workflow/safe_outputs_handler_registry_dispatch.go Registers dispatch and reporting handlers.
pkg/workflow/safe_outputs_handler_registry_artifacts_projects.go Registers artifact and project handlers.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 8/8 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot Please review the latest PR state, refresh the branch if needed, and run the pr-finisher skill before handing back for maintainer review.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 10.3 AIC · ⌖ 9.22 AIC · ⊞ 6.2K ·
Comment /souschef to run again

…plit-safe-outputs-handler

# Conflicts:
#	pkg/workflow/safe_outputs_handler_registry.go
#	pkg/workflow/safe_outputs_handler_registry_issues.go
#	pkg/workflow/safe_outputs_handler_registry_pull_requests.go
#	pkg/workflow/safe_outputs_handler_registry_test.go

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Please review the latest PR state, refresh the branch if needed, and run the pr-finisher skill before handing back for maintainer review.

Generated by [👨‍🍳 PR Sous Chef](https://...

Merged main and resolved conflicts — main had already merged an equivalent registry split (#55482) for the same underlying issue, so this branch now adopts main's version of the affected files and drops the redundant duplicate files this branch had added. Local make fmt/make lint/make test-unit pass (3 pre-existing lint warnings confirmed present on main itself, unrelated). See 7db22d6.

Copilot AI requested a review from gh-aw-bot August 24, 2026 22:40
@pelikhan
pelikhan merged commit f4ed14f into main Aug 24, 2026
2 checks passed
@pelikhan
pelikhan deleted the copilot/deep-report-split-safe-outputs-handler branch August 24, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[deep-report] Split pkg/workflow/safe_outputs_handler_registry.go (1,091 lines, 49-entry closure map) by handler category

4 participants