fix: configure dynamic enclave smoke guard - #8324
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generated-only edit will be overwritten during the next workflow compilation unless added to the postprocessor and tests.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
.github/workflows/smoke-enclave-dynamic-issues-read.lock.yml — This fix is applied only to a generated file, so the next gh aw compile will restore the two… |
What changed in this PR
Hard-codes the GitHub MCP guard policy so the dynamic enclave smoke workflow can start successfully.
Changes:
- Restricts access to approved-integrity data from
github/gh-aw.
| File | Description |
|---|---|
.github/workflows/smoke-enclave-dynamic-issues-read.lock.yml |
Configures the smoke test’s MCP guard policy. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+768
to
+769
| "min-integrity": "approved", | ||
| "repos": ["github/gh-aw"] |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Contributor
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bb72ca5-93c0-4048-970e-bd58994d90e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hard-code the dynamic enclave smoke workflow's shared GitHub MCP guard policy to the repository and integrity level exercised by the smoke test.
The first manual run failed before dynamic execution because
tools.github: falseleftGITHUB_MCP_GUARD_MIN_INTEGRITYandGITHUB_MCP_GUARD_REPOSempty, causing mcpg to reject the generated policy. This lockfile-only change lets the next run proceed far enough to expose any remaining integration failures.Failed baseline: https://github.com/github/gh-aw-firewall/actions/runs/34242136446
Validation
npx jest scripts/ci/smoke-enclave-workflow.test.ts --runInBandgit diff --check