Clarify runtime-backed SDK publishing - #2689
Merged
Merged
Conversation
added 4 commits
September 15, 2026 20:00
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the stated publishing behavior and includes focused coverage for the changed paths.
Review tier: Balanced
Findings: None
What changed in this PR
Clarifies and streamlines runtime-backed SDK package publishing.
Changes:
- Publishes nine validated tarballs sequentially, with the umbrella package last.
- Restricts accepted conflicts by registry type and removes registry readback/tag repair.
- Renames workflow jobs and adds focused publishing/workflow tests.
| File | Description |
|---|---|
.github/workflows/publish.yml |
Renames jobs and simplifies retained-release publication. |
nodejs/scripts/npm-release.js |
Streamlines manifest publishing and conflict handling. |
nodejs/test/npm-release.test.ts |
Tests ordering, validation, concurrency, conflicts, and workflow structure. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stephentoub
approved these changes
Sep 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cd nodejs && npm test -- test/npm-release.test.ts(17 tests passed)cd nodejs && npx prettier --check scripts/npm-release.js test/npm-release.test.tscd nodejs && npx eslint scripts/npm-release.js test/npm-release.test.tscd nodejs && npm run typecheckjs-yamlgit diff --checkactionlintand whole-workflow Prettier reproduce only pre-existing baseline findings aroundconcurrency.queuesupport and workflow formatting.