Skip to content

Clarify runtime-backed SDK publishing - #2689

Merged
stephentoub merged 4 commits into
mainfrom
mackinnonbuck-clarify-sdk-workflow-names
Sep 16, 2026
Merged

stephentoub merged 4 commits into
mainfrom
mackinnonbuck-clarify-sdk-workflow-names

Conversation

@MackinnonBuck

Copy link
Copy Markdown
Collaborator

Summary

  • clarify runtime-backed workflow job names as SDK package build/publication operations
  • align retained-manifest publishing with the established npm/Azure behavior: validate locally, publish the exact nine tarballs sequentially with the umbrella package last, accept only recognized idempotent conflicts, and fail other publish errors
  • remove registry readback, dist-tag repair, and internal clean-install verification from runtime-backed publication
  • add focused helper and workflow tests for functional publishing behavior

Validation

  • cd nodejs && npm test -- test/npm-release.test.ts (17 tests passed)
  • cd nodejs && npx prettier --check scripts/npm-release.js test/npm-release.test.ts
  • cd nodejs && npx eslint scripts/npm-release.js test/npm-release.test.ts
  • cd nodejs && npm run typecheck
  • YAML parse with js-yaml
  • git diff --check

actionlint and whole-workflow Prettier reproduce only pre-existing baseline findings around concurrency.queue support and workflow formatting.

Mackinnon Buck added 4 commits September 15, 2026 20:00
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c525a26b-f951-4bd7-a486-7bf1a3b007c7
@MackinnonBuck
MackinnonBuck requested a review from a team as a code owner September 16, 2026 03:19
Copilot AI balanced review requested due to automatic review settings September 16, 2026 03:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation matches the stated publishing behavior and includes focused coverage for the changed paths.

Review tier: Balanced
Findings: None

What changed in this PR

Clarifies and streamlines runtime-backed SDK package publishing.

Changes:

  • Publishes nine validated tarballs sequentially, with the umbrella package last.
  • Restricts accepted conflicts by registry type and removes registry readback/tag repair.
  • Renames workflow jobs and adds focused publishing/workflow tests.
File Description
.github/​workflows/​publish.yml Renames jobs and simplifies retained-release publication.
nodejs/​scripts/​npm-release.js Streamlines manifest publishing and conflict handling.
nodejs/​test/​npm-release.test.ts Tests ordering, validation, concurrency, conflicts, and workflow structure.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@MackinnonBuck
MackinnonBuck added this pull request to the merge queue Sep 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 16, 2026
@stephentoub
stephentoub added this pull request to the merge queue Sep 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 16, 2026
@stephentoub
stephentoub added this pull request to the merge queue Sep 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 16, 2026
@stephentoub
stephentoub merged commit db6bd6f into main Sep 16, 2026
102 checks passed
@stephentoub
stephentoub deleted the mackinnonbuck-clarify-sdk-workflow-names branch September 16, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants