[Chore] Handle Rust Unknown Enum Collision - #2632
Closed
MRayermannMSFT wants to merge 2 commits into
Closed
MRayermannMSFT wants to merge 2 commits into
MRayermannMSFT wants to merge 2 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
MRayermannMSFT
added
skip-changelog
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted override preserves wire serialization while avoiding the generated Unknown collision.
Review tier: Balanced
Findings: None
What changed in this PR
Updates Rust code generation to resolve collisions between wire enum values and catch-all variants.
Changes:
- Adds a stable
UnknownValueoverride forCatalogTrustEligibility.unknown. - Allows explicit variant-name overrides during string-enum generation.
| File | Description |
|---|---|
scripts/codegen/rust.ts |
Adds and applies the Rust enum variant override. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
This is duplicating #2631, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rust codegen gives the wire value
"unknown"a stableUnknownValuevariant when the catch-all already usesUnknown. The successful branch workflow run generated the CLI update draft with this fix.Why
Copilot CLI
1.0.84-5adds"unknown"toCatalogTrustEligibility. The existing name collision stops the automated CLI update workflow before it can create a pull request.