[Rust] Add wrapper for reading managed settings - #1987
Closed
jbrown1618 wants to merge 5 commits into
Closed
jbrown1618 wants to merge 5 commits into
jbrown1618 wants to merge 5 commits into
Conversation
Expose a top-level Rust Client::read_managed_settings helper for the server-scoped managedSettings.read RPC and preserve the runtime-owned payload as opaque JSON. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 115e51b8-7534-42e6-956b-aa212c360ddc
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44940cff-d077-4e4d-a8ce-613de54ffded
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Rust SDK wrapper for retrieving server-scoped managed settings without creating a session.
Changes:
- Adds
Client::read_managed_settings(). - Introduces
ManagedSettingsReadResult. - Tests successful and runtime-error responses over in-memory JSON-RPC.
Show a summary per file
| File | Description |
|---|---|
rust/src/lib.rs |
Adds the managed-settings RPC wrapper. |
rust/src/types.rs |
Defines the public response type. |
rust/tests/managed_settings_test.rs |
Verifies request scope and response handling. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 44940cff-d077-4e4d-a8ce-613de54ffded
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: db3411a4-ec90-4a62-ac9c-c11be517c3d5
jbrown1618
marked this pull request as ready for review
August 10, 2026 15:25
jbrown1618
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client::read_managed_settings()as a top-level Rust SDK helper for the server-scopedmanagedSettings.readJSON-RPC method.ManagedSettingsJSON result type so the SDK preserves the runtime-owned canonical payload without reinterpreting policy.managedSettings.readwith no session ID before anysession.createcall.Dependency
The companion runtime change, github/copilot-agent-runtime#12700, is already merged and present in the current pinned runtime version,
@github/copilot1.0.79-9.The generated RPC schema in this repo does not currently expose
managedSettings.readas a typed top-level RPC method, so this PR adds the Rust top-level wrapper directly rather than hand-editing generated RPC output.github/copilot-hostwill consume this Rust SDK wrapper to include managed settings during environment registration.Validation
rustfmtdirect check usingnightly-2026-04-14rustfmt on changed Rust filescargo test --test managed_settings_testwith Rust 1.94.0cargo clippy --all-features --all-targets -- -D warningswith Rust 1.94.0Limit:
cargo test --all-featureswas attempted but stopped after several minutes because it appeared stuck downloading the bundled runtime package (@github/copilot-darwin-arm64).