Fix jbang-example.java to use actual version instead of Maven placeholder#63
Open
brunoborges wants to merge 2 commits intomainfrom
Open
Fix jbang-example.java to use actual version instead of Maven placeholder#63brunoborges wants to merge 2 commits intomainfrom
brunoborges wants to merge 2 commits intomainfrom
Conversation
…lder
Replace ${project.version} with a real version number (0.2.2-java.1) in
jbang-example.java since this file is not Maven-filtered. Also add a
fallback sed pattern in the release workflow to handle the placeholder
during the transition.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the JBang example to use a concrete released SDK version (since ${project.version} is not Maven-filtered at repo root) and adjusts the release workflow so future releases still rewrite the dependency version correctly.
Changes:
- Replaced the unresolved Maven placeholder in
jbang-example.javawith0.2.2-java.1. - Updated
publish-maven.ymlto also rewrite the literal${project.version}form when bumping versions during release.
Show a summary per file
| File | Description |
|---|---|
jbang-example.java |
Pins the JBang //DEPS line to a real released version. |
.github/workflows/publish-maven.yml |
Adds an extra sed replacement intended to handle ${project.version} in jbang-example.java during releases. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
${project.version}with a real version number injbang-example.java. The Maven placeholder was never resolved for this file since it's not processed by Maven's resource filtering (it lives at the repo root, not undersrc/site/markdown/).Changes
jbang-example.java: Replaced${project.version}with0.2.2-java.1(latest release).github/workflows/publish-maven.yml: Added a fallbacksedpattern to match and replace the${project.version}literal during the transition, so future releases will correctly update the versionTesting
DocumentationSamplesTest— passes successfully