Fix stale snapshot version in README and automate updates#62
Open
brunoborges wants to merge 1 commit intomainfrom
Open
Fix stale snapshot version in README and automate updates#62brunoborges wants to merge 1 commit intomainfrom
brunoborges wants to merge 1 commit intomainfrom
Conversation
Update the snapshot version in README.md from 0.2.1-java.0-SNAPSHOT to 0.2.3-java.1-SNAPSHOT to match the current pom.xml. Add a sed command to the publish-maven workflow to update the snapshot version during releases, preventing it from going stale again. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the README snapshot dependency version to match the current pom.xml development version, and adjusts the Maven publish workflow so future releases also update the README’s -SNAPSHOT version automatically.
Changes:
- Update
README.mdsnapshot dependency version to0.2.3-java.1-SNAPSHOT. - Extend
publish-maven.ymlto update the README snapshot<version>...-SNAPSHOT</version>usingsteps.versions.outputs.dev_versionduring releases.
Show a summary per file
| File | Description |
|---|---|
| README.md | Fixes stale snapshot dependency version to match the current development version. |
| .github/workflows/publish-maven.yml | Automates updating the README snapshot version during the release workflow to prevent staleness. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The snapshot version in README.md was stuck at
0.2.1-java.0-SNAPSHOTwhile the current pom.xml is at0.2.3-java.1-SNAPSHOT. The release workflow's sed patterns only matched non-SNAPSHOT<version>tags, so the snapshot line was never updated during releases.Changes
0.2.1-java.0-SNAPSHOT→0.2.3-java.1-SNAPSHOT-SNAPSHOTversion in README during releases usingDEV_VERSIONfrom the versions step, preventing this from going stale again