Repository navigation
Java: Delete old deprecated SSA classes and predicates. - #22996
Merged
Merged
Conversation
hvitved
approved these changes
Nov 3, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The change removes public SSA library APIs without the required unreleased Java breaking-change note.
1 open issue
What changed in this PR
This pull request removes deprecated Java SSA compatibility APIs and obsolete integer-guard helpers, leaving the newer SSA and range-analysis implementations in place.
Changes:
- Deletes deprecated SSA classes and predicates from the public Java SSA library.
- Removes their supporting predicates from the internal SSA implementation.
- Removes deprecated integer comparison, bound-guard, and compatibility APIs.
- Review note: add an unreleased Java change note categorized as
breakingfor the removed public APIs.
| File | Summary |
|---|---|
java/ql/lib/semmle/code/java/dataflow/SSA.qll |
Removes deprecated public SSA classes and predicates. |
java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll |
Removes internal support predicates for the deleted SSA APIs. |
java/ql/lib/semmle/code/java/dataflow/IntegerGuards.qll |
Removes deprecated integer-comparison and bound-guard APIs. |
Review effort: Lite (auto)
| } | ||
| } | ||
|
|
||
| private predicate hasQualifierUpdate(SsaImplicitWrite def) { |
aschackmull
added
no-change-note-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.